From owner-freebsd-current@FreeBSD.ORG  Sat Jul 31 09:47:55 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0C5B016A4ED
	for <current@freebsd.org>; Sat, 31 Jul 2004 09:47:55 +0000 (GMT)
Received: from www.mmlab.cse.yzu.edu.tw (www.mmlab.cse.yzu.edu.tw
	[140.138.145.166])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 672B843D5E
	for <current@freebsd.org>; Sat, 31 Jul 2004 09:47:52 +0000 (GMT)
	(envelope-from avatar@mmlab.cse.yzu.edu.tw)
Received: by www.mmlab.cse.yzu.edu.tw (qmail, from userid 1000)
	id D7EC74EFCD8; Sat, 31 Jul 2004 17:47:15 +0800 (CST)
Received: from localhost (localhost [127.0.0.1])
	by www.mmlab.cse.yzu.edu.tw (qmail) with ESMTP id AB5724EFCD7;
	Sat, 31 Jul 2004 17:47:15 +0800 (CST)
Date: Sat, 31 Jul 2004 17:47:15 +0800 (CST)
From: Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>
To: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@DeepCore.dk>
In-Reply-To: <410B61F2.90504@DeepCore.dk>
Message-ID: <04073117462818.89117@www.mmlab.cse.yzu.edu.tw>
References: <410AD054.8070202@root.org> <410B61F2.90504@DeepCore.dk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
cc: current@freebsd.org
cc: Nate Lawson <nate@root.org>
Subject: Re: memory corruption/panic solved ("FAILURE - ATAPI_IDENTIFY no
 interrupt")
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Jul 2004 09:47:55 -0000

On Sat, 31 Jul 2004, [ISO-8859-1] Søren Schmidt wrote:
[...]
> Thats the real bug, donecount should be reset on retry..
>
> > @@ -561,11 +561,12 @@
> >  		request->data = (caddr_t)atadev->param;
> >  		request->bytecount = sizeof(struct ata_params);
> >  		request->transfersize = DEV_BSIZE;
> > +		request->donecount = 0;
> >  		ata_queue_request(request);
> >  		if (!(error = request->result))
> >  		    break;
> >  	    }
>
> This part should be all thats needed IMHO...

I've tested this, and it worked on my T40.