From owner-freebsd-hackers Wed Jun 9 4:36:51 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from iquest3.iquest.net (iquest3.iquest.net [209.43.20.203]) by hub.freebsd.org (Postfix) with SMTP id 5F32A14C42 for ; Wed, 9 Jun 1999 04:36:49 -0700 (PDT) (envelope-from toor@dyson.iquest.net) Received: (qmail 17761 invoked from network); 9 Jun 1999 11:36:47 -0000 Received: from dyson.iquest.net (198.70.144.127) by iquest3.iquest.net with SMTP; 9 Jun 1999 11:36:47 -0000 Received: (from root@localhost) by dyson.iquest.net (8.9.1/8.9.1) id GAA15180; Wed, 9 Jun 1999 06:36:45 -0500 (EST) From: "John S. Dyson" Message-Id: <199906091136.GAA15180@dyson.iquest.net> Subject: Re: problem for the VM gurus In-Reply-To: from Brian Feldman at "Jun 9, 99 07:26:43 am" To: green@unixhelp.org (Brian Feldman) Date: Wed, 9 Jun 1999 06:36:45 -0500 (EST) Cc: dyson@iquest.net, hgoldste@bbs.mpcs.com, freebsd-hackers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL32 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Wed, 9 Jun 1999, John S. Dyson wrote: > > > Howard Goldstein said: > > > On Mon, 7 Jun 1999 18:38:51 -0400 (EDT), Brian Feldman wrote: > > > : On Mon, 7 Jun 1999, Matthew Dillon wrote: > > > : > ... what version of the operating system? > > > : 4.0-CURRENT > > > > > > 3.2R too... > > > > > I just checked the source (CVS) tree, and something bad happend > > between 1.27 and 1.29 on ufs_readwrite.c. Unless other things > > had been changed to make the problem go away, the recursive vnode > > thing was broken then. I am surprised that was changed that long > > ago. (The breakage is an example of someone making a change, and > > not either understanding why the code was there, or forgetting to > > put the alternative into the code.) > > Is that the limit to Bruce's fu*kup, or did he break it elsewhere, too? It'd be > nice to get this reversed since it's been found. And FWIW, semenu seems to > be the only one to have anything to handle IN_RECURSE, probably because his > NTFS code was recently committed and not mangled. > I think that I had most of the filesystems fixed somewhere (in my private tree or in the standard one.) It is easy to make mistakes, but he was also right that there is probably a better way to do it. I suggest putting the recurse stuff back in for a quick fix, and working the problem in more detail in the future. (I could even be wrong if this is where the problem came in -- so much has happened since then :-)). John To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message