From owner-svn-ports-all@freebsd.org Thu Sep 10 01:37:56 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EECD2A0078A for ; Thu, 10 Sep 2015 01:37:56 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B176E1ED0 for ; Thu, 10 Sep 2015 01:37:55 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: (qmail 21279 invoked by uid 89); 10 Sep 2015 01:37:54 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 10 Sep 2015 01:37:54 -0000 Received: (qmail 21204 invoked by uid 89); 10 Sep 2015 01:37:36 -0000 Received: by simscan 1.3.1 ppid: 21195, pid: 21200, t: 0.0997s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 10 Sep 2015 01:37:36 -0000 Received: (qmail 30884 invoked by uid 89); 10 Sep 2015 01:37:36 -0000 Received: by simscan 1.4.0 ppid: 30850, pid: 30871, t: 0.7900s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 10 Sep 2015 01:37:35 -0000 From: Jan Beich To: Jason Unovitch Cc: Chris Hutchinson , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396547 - in head/textproc: . smi In-Reply-To: <201509100045.t8A0jQFW087140@repo.freebsd.org> (Jason Unovitch's message of "Thu, 10 Sep 2015 00:45:26 +0000 (UTC)") References: <201509100045.t8A0jQFW087140@repo.freebsd.org> Date: Thu, 10 Sep 2015 03:37:23 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2015 01:37:57 -0000 --=-=-= Content-Type: text/plain Jason Unovitch writes: > +post-patch: > + ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \ CC is defined by default to a sane value in both GNU and BSD make. One can do '/^CC/d' but see below for better way. > + -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \ ^^^ Typo: l .vs I. It still works because PREFIX is also passed via MAKE_ENV. > + -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \ > + ${WRKSRC}/config.mk If possible try to avoid patching makefiles if overriding a few variables is enough. For one, your entire post-patch can be: MAKE_ARGS= CC="${CC}" PREFIX="${PREFIX}" MANPREFIX="${MANPREFIX}" --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJV8N7TXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bD/AH/R7YSyommIay+lFB0e6wSmlI w6ijRpTNfhGj7tHMpAbm4RxvM00NQvD7CrkZkObsz1tN61wzVhaef7/CK4/fsPuq dQJTIsOG7TUQDIrfNHMU7coky/wKM4TDFeA/UGzsz3G7CeKG2vCZel9gDNWbhk7e uAS2t4CJnN3cQ3dkuIGiH6GhAh7uke2Km+WtfgeLqkIoHgWVXA7q4bebFijFS5R1 OSZNoQFODXKY0D7/BxIlL8olWox+HQ+5Hs1GO56ztdu67W3sBPmobWH30QsSv1O5 /dv6hDqi8o8C/0XgvvZl1+QQZXRnjOsUU9d4N0WQ+OzNSSYXok8PLAAAzepgf0g= =Xj2z -----END PGP SIGNATURE----- --=-=-=--