Date: Fri, 04 May 2012 13:15:00 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, Garrett Cooper <yanegomi@gmail.com>, "svn-src-all@freebsd.org" <svn-src-all@FreeBSD.org>, "svn-src-head@freebsd.org" <svn-src-head@FreeBSD.org>, "kmoore@freebsd.org" <kmoore@FreeBSD.org>, Josh Paetzel <jpaetzel@FreeBSD.org> Subject: Re: svn commit: r235005 - head/usr.sbin/pc-sysinstall/backend Message-ID: <4FA438C4.3080701@FreeBSD.org> In-Reply-To: <20120504182200.GD1604@azathoth.lan> References: <201205041531.q44FVaYF010236@svn.freebsd.org> <F68AFF89-B9C3-494B-8B61-7130999BC354@gmail.com> <20120504182200.GD1604@azathoth.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/04/2012 11:22 AM, Baptiste Daroussin wrote:
>>> > > fetch -s "${FETCHFILE}" >${SIZEFILE}
>>> > > SIZE="`cat ${SIZEFILE}`"
>>> > > - SIZE="`expr ${SIZE} / 1024`"
>>> > > + SIZE=$((SIZE/1024))
>> >
>> > Bug; should be '$SIZE/'
> No this is perfectly valid
Yes, that works, but it's not our usual style. However, the point is
moot as that whole block should be reduced down to:
SIZE=$(( `fetch -s "${FETCHFILE}"` / 1024 ))
If SIZEFILE is needed elsewhere that's a different matter, but as it is
that's a hot mess.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FA438C4.3080701>