From owner-svn-src-all@FreeBSD.ORG  Fri May  4 20:15:02 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id A54481065675;
	Fri,  4 May 2012 20:15:02 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id B424C14DB89;
	Fri,  4 May 2012 20:15:00 +0000 (UTC)
Message-ID: <4FA438C4.3080701@FreeBSD.org>
Date: Fri, 04 May 2012 13:15:00 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120410 Thunderbird/11.0.1
MIME-Version: 1.0
To: Baptiste Daroussin <bapt@FreeBSD.org>
References: <201205041531.q44FVaYF010236@svn.freebsd.org>
	<F68AFF89-B9C3-494B-8B61-7130999BC354@gmail.com>
	<20120504182200.GD1604@azathoth.lan>
In-Reply-To: <20120504182200.GD1604@azathoth.lan>
X-Enigmail-Version: 1.4
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>,
	Garrett Cooper <yanegomi@gmail.com>,
	"svn-src-all@freebsd.org" <svn-src-all@FreeBSD.org>,
	"svn-src-head@freebsd.org" <svn-src-head@FreeBSD.org>,
	"kmoore@freebsd.org" <kmoore@FreeBSD.org>,
	Josh Paetzel <jpaetzel@FreeBSD.org>
Subject: Re: svn commit: r235005 - head/usr.sbin/pc-sysinstall/backend
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 May 2012 20:15:02 -0000

On 05/04/2012 11:22 AM, Baptiste Daroussin wrote:
>>> > >   fetch -s "${FETCHFILE}" >${SIZEFILE}
>>> > >   SIZE="`cat ${SIZEFILE}`"
>>> > > -  SIZE="`expr ${SIZE} / 1024`"
>>> > > +  SIZE=$((SIZE/1024))
>> > 
>> > Bug; should be '$SIZE/'
> No this is perfectly valid

Yes, that works, but it's not our usual style. However, the point is
moot as that whole block should be reduced down to:

SIZE=$(( `fetch -s "${FETCHFILE}"` / 1024 ))

If SIZEFILE is needed elsewhere that's a different matter, but as it is
that's a hot mess.