From owner-cvs-src@FreeBSD.ORG Tue Apr 25 23:56:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91DB916A47D; Tue, 25 Apr 2006 23:56:00 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2AD843D78; Tue, 25 Apr 2006 23:55:55 +0000 (GMT) (envelope-from mj@feral.com) Received: from ns1.feral.com (localhost [127.0.0.1]) by ns1.feral.com (8.13.6/8.13.6) with ESMTP id k3PNtpTe064318; Tue, 25 Apr 2006 16:55:51 -0700 (PDT) (envelope-from mj@feral.com) Received: from localhost (mjacob@localhost) by ns1.feral.com (8.13.6/8.13.4/Submit) with ESMTP id k3PNtpgn064315; Tue, 25 Apr 2006 16:55:51 -0700 (PDT) (envelope-from mj@feral.com) X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs Date: Tue, 25 Apr 2006 16:55:51 -0700 (PDT) From: Matthew Jacob X-X-Sender: mjacob@ns1.feral.com To: Warner Losh In-Reply-To: <20060425.173236.74726638.imp@bsdimp.com> Message-ID: <20060425165324.M64286@ns1.feral.com> References: <444E7750.206@samsco.org> <200604251540.00170.jhb@freebsd.org> <444E7BFE.4040800@samsco.org> <20060425.173236.74726638.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, scottl@samsco.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bce if_bcereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthew Jacob List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2006 23:56:01 -0000 > The problem is that PAE's bus_size_t is a 32-bit quantity, when it > should be a 64-bit quantity: > > #ifdef PAE > typedef uint64_t bus_addr_t; > #else > typedef uint32_t bus_addr_t; > #endif > typedef uint32_t bus_size_t; > > For bus addresses, we should use bus_addr_t, of course, but the above > is wrong. I don't have a PAE machine, or I'd commit my local changes > that fix this... > Why do you believe that it should be a 64 bit quantity under PAE? Strictly speaking, I don't believe it is. PAE allows you to *address* 36 physical address bits of memory using Dual Address cycles, but the underlying bus is still a 32 bit bus.