Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Nov 2018 14:24:59 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Eric Turgeon <ericbsd@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r485330 - head/x11/py-xcffib
Message-ID:  <20181121132459.yv2pex2m3o2hnwg3@ogg.in.absolight.net>
In-Reply-To: <201811191624.wAJGOQpS030238@repo.freebsd.org>
References:  <201811191624.wAJGOQpS030238@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--wnyb6ud7iadpfjua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 19, 2018 at 04:24:26PM +0000, Eric Turgeon wrote:
> Author: ericbsd
> Date: Mon Nov 19 16:24:25 2018
> New Revision: 485330
> URL: https://svnweb.freebsd.org/changeset/ports/485330
>=20
> Log:
>   add.x11/py-xcffib.missing._ffi.py.from.autoplist.in.pkg-plist
>  =20
>   Approved by:	mentors (implicit)
>=20
> Added:
>   head/x11/py-xcffib/pkg-plist   (contents, props changed)
> Modified:
>   head/x11/py-xcffib/Makefile
>=20
> Modified: head/x11/py-xcffib/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/x11/py-xcffib/Makefile	Mon Nov 19 16:17:49 2018	(r485329)
> +++ head/x11/py-xcffib/Makefile	Mon Nov 19 16:24:25 2018	(r485330)
> @@ -16,6 +16,7 @@ LICENSE_FILE=3D	${WRKSRC}/LICENSE
>  LIB_DEPENDS=3D	libxcb.so:x11/libxcb
>  BUILD_DEPENDS=3D	${PYTHON_PKGNAMEPREFIX}cffi>=3D1.1.0:devel/py-cffi@${PY=
_FLAVOR} \
>  		${PYTHON_PKGNAMEPREFIX}six>0:devel/py-six@${PY_FLAVOR}
> +RUN_DEPENDS=3D	${BUILD_DEPENDS}

This is wrong.  BUILD_DEPENDS can get many build only dependencies,
which then gets added to the runtime dependencies.  See:
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#=
makefile-run_depends

--=20
Mathieu Arnold

--wnyb6ud7iadpfjua
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlv1XKpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkhXmBAAgydrJzPQ04m1pGFWsiUM+LDG5UvaV7n2xB0N/0SeEAIY1m69FgRWHn7A
hnLSkg10ea+i2JXdGFN5N0lj4EKtK96fpiNRAVSnR27LyqZ/fVN6GYLAOedjL7/a
WtFu9AMUcCa0QYOHvRqUakXCe/qA2NsH7nE+zyTpJP5Geo354yHx3iz/vmSZAMEq
TinH1u1TybwCD1NRIJlullro/5VqpfuYfJgwEesHfUGf+y8DjkKB14+x7F+bP67O
8vzd6YY9JJ8DHG6mfCv8woLetY5PHq5PhCEm+k5TV4mR/cv9Uioz3OLqKPzEP4VB
btRrTKpi8fZ6Zcz6NJXb99BdXGnWNoueIr1gcpjJTHD3Rlg/WX8/NWthHSwTBKwg
X0Qa/FVNejzlH5sVVSpIc5MkKvF/aTAaDhHe9bj0szMIOsuiE+6tSVLxiPm43Lam
f3XYgYwwBIIPBbTzxofjz1N5bG9JgE+vyO7gDUPBIlJupzo8wT/68970vhXb9ON/
KlY3C6/MRcW6Zrl3Hd/U3VDjNylVYJp4ZQeivu+ShHyzeDUCcyqxGdQalIXEEwJd
K/svKis37m1RTE1vsMP8HeA6bQREIxdk4kd5USXnwKN03JKJF0Xm7Yc9wKKRwUVU
4MkMongKWRBcxc4dcGUkJx4l3wIAeftJ2hXn4iiAMmo+/g3FVYA=
=6nvc
-----END PGP SIGNATURE-----

--wnyb6ud7iadpfjua--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181121132459.yv2pex2m3o2hnwg3>