From owner-cvs-all@FreeBSD.ORG  Mon May 21 04:25:51 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3B24416A480;
	Mon, 21 May 2007 04:25:51 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from ns1.feral.com (ns1.feral.com [192.67.166.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 15E2013C45E;
	Mon, 21 May 2007 04:25:51 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from ns1.feral.com (localhost [127.0.0.1])
	by ns1.feral.com (8.14.1/8.14.1) with ESMTP id l4L4Pg1i071615;
	Sun, 20 May 2007 21:25:50 -0700 (PDT)
	(envelope-from mjacob@freebsd.org)
Received: from localhost (mjacob@localhost)
	by ns1.feral.com (8.14.1/8.14.1/Submit) with ESMTP id l4L4Pg81071612;
	Sun, 20 May 2007 21:25:42 -0700 (PDT)
	(envelope-from mjacob@freebsd.org)
X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs
Date: Sun, 20 May 2007 21:25:42 -0700 (PDT)
From: mjacob@freebsd.org
To: Bruce Evans <bde@optusnet.com.au>
In-Reply-To: <20070521132204.D86236@besplex.bde.org>
Message-ID: <20070520212020.D71516@ns1.feral.com>
References: <200705201649.l4KGnApl032671@repoman.freebsd.org>
	<20070521132204.D86236@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@freebsd.org, src-committers@freebsd.org,
	Matt Jacob <mjacob@freebsd.org>, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/hptmv ioctl.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: mjacob@freebsd.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2007 04:25:51 -0000

>> mjacob      2007-05-20 16:49:10 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/dev/hptmv        ioctl.c
>>  Log:
>>  Make gcc 4.2 happy by initiatlizing controller && channel prior
>>  to a call to a function which *might* then initialize them.
>>
>>  MFC after:      3 days
>
> Isn't the bug that the function doesn't always initialize them?
>
> Bruce
>

That was a meta-comment- I should have made it clearer. The function 
get_disk_location *will* always init them, but gcc-4.2 doesn't know 
that, and unlike previous versions of gcc, gcc-4.2 no longer will assume 
that a function that you pass a pointer to local data to will actually 
fill them in.

-matt