From owner-cvs-all Mon Sep 17 3:57:58 2001 Delivered-To: cvs-all@freebsd.org Received: from tao.org.uk (genius.tao.org.uk [212.135.162.51]) by hub.freebsd.org (Postfix) with ESMTP id D5A5E37B40F; Mon, 17 Sep 2001 03:57:47 -0700 (PDT) Received: by tao.org.uk (Postfix, from userid 100) id 99CC77A; Mon, 17 Sep 2001 11:57:42 +0100 (BST) Date: Mon, 17 Sep 2001 11:57:42 +0100 From: Josef Karthauser To: knu@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Thoughts on 'Attic'. Message-ID: <20010917115742.A11675@tao.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In the recent change to log_accum.pl I added deltas for removed files. In this patch I removed the word 'Attic' from the output, because Attic is really a hidden internal to CVS and would never be used in a cvs command explicitly. Looking at the following commit I notice however that this was never done in the case of modifications to files. I'm inclined to modify the code to remove the word Attic here too. Opinions? Joe p.s. I know that this will have some ramifications in other areas. For instance the cvsweb.cgi script makes a mistake, in my opinion. # cd /usr/src/release/sysinstall # cvs log -r1.3.8.1 dhcp.c [cut] ---------------------------- revision 1.3.8.1 date: 2001/09/17 07:30:17; author: jkh; state: Exp; lines: +3 -1 MFC: Usual collection of 11th-hour glitches: o Close login_cap hole by temporarily disabling $HOME login caps o Fix multiple value returns with DHCP in sysinstall o Add some misc FTP mirrors as one contribution towards world peace. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D Where as: http://www.FreeBSD.org/cgi/cvsweb.cgi/src/release/sysinstall/dhcp.c?rev= =3D1.3.8.1 doesn't work, and you have to instead use: http://www.FreeBSD.org/cgi/cvsweb.cgi/src/release/sysinstall/Attic/dhcp= .c?rev=3D1.3.8.1 On Mon, Sep 17, 2001 at 12:30:18AM -0700,=20 > jkh 2001/09/17 00:30:18 PDT >=20 > Modified files: (Branch: RELENG_4_4) > lib/libutil login.conf.5 login_cap.c=20 > release/sysinstall dhcp.c menus.c tcpip.c=20 > Log: > MFC: Usual collection of 11th-hour glitches: > =20 > o Close login_cap hole by temporarily disabling $HOME login caps > o Fix multiple value returns with DHCP in sysinstall > o Add some misc FTP mirrors as one contribution towards world peace. > =20 > Revision Changes Path > 1.22.2.11.2.1 +3 -1 src/lib/libutil/login.conf.5 > 1.17.2.2.4.1 +10 -3 src/lib/libutil/login_cap.c > 1.3.8.1 +3 -1 src/release/sysinstall/Attic/dhcp.c > 1.252.2.49.2.1 +14 -2 src/release/sysinstall/Attic/menus.c > 1.103.2.15.2.2 +2 -2 src/release/sysinstall/Attic/tcpip.c --FCuugMFkClbJLl1L Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjul1yYACgkQXVIcjOaxUBYRCQCg5Ij2m2XVJguS9Luvx+K+MOa4 zj4An3HziymPFOTeuPfTU4PsAWcGxtN5 =mfvf -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message