From owner-freebsd-current@FreeBSD.ORG Sat Nov 22 21:58:40 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3601716A4CE; Sat, 22 Nov 2003 21:58:40 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87AE143F93; Sat, 22 Nov 2003 21:58:39 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 79B842ED442; Sat, 22 Nov 2003 21:58:39 -0800 (PST) Date: Sat, 22 Nov 2003 21:58:39 -0800 From: Alfred Perlstein To: Daniel Eischen Message-ID: <20031123055839.GH35957@elvis.mu.org> References: <20031123023649.GG35957@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i cc: re@freebsd.org cc: current@freebsd.org Subject: Re: [PATCH] please review. file descriptor passing for libc_r. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Nov 2003 05:58:40 -0000 * Daniel Eischen [031122 20:46] wrote: > On Sat, 22 Nov 2003, Alfred Perlstein wrote: > > > This should make things work properly for apps that are linked > > against libc_r and use filedescriptor passing. > > > > Can someone review and approve it please? > > This isn't needed. Any time a file descriptor is used, a call > should first be made to _FD_LOCK() which ends up calling > _thread_fd_lock() which then calls _thread_fd_table_init() > for the file descriptor. > > If there's a reason that this is necessary, then I think it > is just covering up another problem. I think I made this > same comment a couple of years ago ;-) Oh, ok paranioa on my part then. thanks! -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684