From owner-svn-src-all@FreeBSD.ORG Fri Sep 19 17:32:22 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 83F513F7; Fri, 19 Sep 2014 17:32:22 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5A1F61BE; Fri, 19 Sep 2014 17:32:22 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E588AB982; Fri, 19 Sep 2014 13:32:20 -0400 (EDT) From: John Baldwin To: Steven Hartland Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Date: Fri, 19 Sep 2014 12:34:15 -0400 Message-ID: <11362806.9nSfhFyLDg@ralph.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; ) In-Reply-To: <5783417ED470465B9C816FCA02B3690D@multiplay.co.uk> References: <201409181655.s8IGtgft042984@svn.freebsd.org> <5783417ED470465B9C816FCA02B3690D@multiplay.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 19 Sep 2014 13:32:21 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Will Andrews X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2014 17:32:22 -0000 On Thursday, September 18, 2014 06:37:28 PM Steven Hartland wrote: > You don't need a seperate TUNABLE_INT declations any more since the > excellent SYSCTL refactor. That is my fault. I wasn't certain if SYSCTL_PROC() would work correctly when Will asked me on IRC, but it seems it does so long as the tunable type is one it knows how to parse (e.g. CTLTYPE_INT). If your sysctl wants a "blob" (CTLTYPE_OPAQUE or the like), then you still need your own tunable fetching handler. -- John Baldwin