From owner-freebsd-bugs  Sun Aug 24 05:40:05 1997
Return-Path: <owner-freebsd-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id FAA00679
          for bugs-outgoing; Sun, 24 Aug 1997 05:40:05 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id FAA00650;
          Sun, 24 Aug 1997 05:40:03 -0700 (PDT)
Resent-Date: Sun, 24 Aug 1997 05:40:03 -0700 (PDT)
Resent-Message-Id: <199708241240.FAA00650@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, nnd@nnd.itfs.nsk.su
Received: from nnd.itfs.nsk.su (nnd.itfs.nsk.su [193.124.36.42])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id FAA00584
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 24 Aug 1997 05:39:38 -0700 (PDT)
Received: (from root@localhost)
	by nnd.itfs.nsk.su (8.8.7/8.8.5) id TAA07347;
	Sun, 24 Aug 1997 19:45:08 +0700 (NSS)
Message-Id: <199708241245.TAA07347@nnd.itfs.nsk.su>
Date: Sun, 24 Aug 1997 19:45:08 +0700 (NSS)
From: "Nickolay N. Dudorov" <nnd@nnd.itfs.nsk.su>
Reply-To: nnd@nnd.itfs.nsk.su
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/4368: ${MAKE} ${.MAKEFLAGS} is superfluous
Sender: owner-freebsd-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         4368
>Category:       bin
>Synopsis:       ${MAKE} ${.MAKEFLAGS} is superfluous
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 24 05:40:01 PDT 1997
>Last-Modified:
>Originator:     Nickolay N. Dudorov
>Organization:
NTP Infoteka
>Release:        FreeBSD 3.0-CURRENT i386
>Environment:

		FreeBSD 3.0-CURRENT i386

>Description:

	Current src/Makefile contains lines of the form:

	... ${MAKE} ${.MAKEFLAGS} ...

	This construct is not a bug but have no sense at all ;-(
because 'make'

	1) process all options from environment variable "MAKEFLAGS"
AND
	2) sets environment variable "MAKEFLAGS" to the value
	   of make's own variable ".MAKEFLAGS"

>How-To-Repeat:

	Observe this lines of code from src/usr.bin/make/main.c:

/* Next line - 109: */
#define MAKEFLAGS       ".MAKEFLAGS"

/* Next line - 590: */
	/*
	 * First snag any flags out of the MAKE environment variable.
	 * (Note this is *not* MAKEFLAGS since /bin/make uses that and it's
	 * in a different format).
	 */
#ifdef POSIX
	Main_ParseArgLine(getenv("MAKEFLAGS"));
#else
	Main_ParseArgLine(getenv("MAKE"));
#endif

/* Next line - 689: */
	/* Install all the flags into the MAKE envariable. */
	if (((p = Var_Value(MAKEFLAGS, VAR_GLOBAL, &p1)) != NULL) && *p)
#ifdef POSIX
		setenv("MAKEFLAGS", p, 1);
#else
		setenv("MAKE", p, 1);
#endif


>Fix:
	
	Change all "... ${MAKE} ${.MAKEFLAGS} ..." to just
"... ${MAKE} ..." all over the world :-)


>Audit-Trail:
>Unformatted: