From owner-freebsd-fs@FreeBSD.ORG Sat Jul 19 19:22:36 2003 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4ECEC37B401 for ; Sat, 19 Jul 2003 19:22:36 -0700 (PDT) Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id C233643F3F for ; Sat, 19 Jul 2003 19:22:35 -0700 (PDT) (envelope-from tim@robbins.dropbear.id.au) Received: from mail.robbins.dropbear.id.au (210.50.202.126) by smtp01.syd.iprimus.net.au (7.0.018) id 3F146D0A00103494 for freebsd-fs@freebsd.org; Sun, 20 Jul 2003 12:22:34 +1000 Received: by mail.robbins.dropbear.id.au (Postfix, from userid 1000) id 41CCFC91F; Sun, 20 Jul 2003 12:22:30 +1000 (EST) Date: Sun, 20 Jul 2003 12:22:30 +1000 From: Tim Robbins To: freebsd-fs@freebsd.org Message-ID: <20030720022230.GA82881@dilbert.robbins.dropbear.id.au> References: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> User-Agent: Mutt/1.4.1i Subject: Re: NFS ftruncate patch for review X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 02:22:36 -0000 On Fri, Jul 18, 2003 at 04:41:20PM +1000, Tim Robbins wrote: > Any comments on this patch? The referenced PR contains more comments and a > test program. It's not obvious from the diff, but the changes are to > nfs_setattr() in the va_size != VNOVAL && v_type == VREG case. It turns out that it's nfs_loadattrcache() that is changing n_size when called indirectly from nfs_meta_setsize() in the test case. (Re-)setting n_size before returning from nfs_setattr() is still correct, but the comment was wrong. Tim