From owner-svn-ports-head@freebsd.org Wed Nov 28 21:13:55 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D2F6113D8C7; Wed, 28 Nov 2018 21:13:55 +0000 (UTC) (envelope-from tcberner@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0D75789556; Wed, 28 Nov 2018 21:13:55 +0000 (UTC) (envelope-from tcberner@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E267E7DDB; Wed, 28 Nov 2018 21:13:54 +0000 (UTC) (envelope-from tcberner@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id wASLDsUQ033191; Wed, 28 Nov 2018 21:13:54 GMT (envelope-from tcberner@FreeBSD.org) Received: (from tcberner@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id wASLDsPt033189; Wed, 28 Nov 2018 21:13:54 GMT (envelope-from tcberner@FreeBSD.org) Message-Id: <201811282113.wASLDsPt033189@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: tcberner set sender to tcberner@FreeBSD.org using -f From: "Tobias C. Berner" Date: Wed, 28 Nov 2018 21:13:54 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r486149 - in head/net/messagelib: . files X-SVN-Group: ports-head X-SVN-Commit-Author: tcberner X-SVN-Commit-Paths: in head/net/messagelib: . files X-SVN-Commit-Revision: 486149 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0D75789556 X-Spamd-Result: default: False [1.18 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_SPAM_SHORT(0.37)[0.365,0]; NEURAL_SPAM_MEDIUM(0.31)[0.308,0]; NEURAL_SPAM_LONG(0.51)[0.511,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 21:13:55 -0000 Author: tcberner Date: Wed Nov 28 21:13:54 2018 New Revision: 486149 URL: https://svnweb.freebsd.org/changeset/ports/486149 Log: net/messagelib: address CVE-2018-19516 messagelib is the library used by KMail to display emails. messagelib by default displays emails as plain text, but gives the user an option to "Prefer HTML to plain text" in the settings and if that option is not enabled there is way to enable HTML display when an email contains HTML. Some HTML emails can trick messagelib into opening a new browser window when displaying said email as HTML. This happens even if the option to allow the HTML emails to access remote servers is disabled in KMail settings. This means that the owners of the servers referred in the email can see in their access logs your IP address. https://www.kde.org/info/security/advisory-20181128-1.txt MFH: 2018Q4 Security: c7b1af20-f34f-11e8-9cde-e0d55e2a8bf9 Added: head/net/messagelib/files/ head/net/messagelib/files/patch-git_347659 (contents, props changed) Modified: head/net/messagelib/Makefile Modified: head/net/messagelib/Makefile ============================================================================== --- head/net/messagelib/Makefile Wed Nov 28 21:07:31 2018 (r486148) +++ head/net/messagelib/Makefile Wed Nov 28 21:13:54 2018 (r486149) @@ -2,7 +2,7 @@ PORTNAME= messagelib DISTVERSION= ${KDE_APPLICATIONS_VERSION} -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= net kde kde-applications MAINTAINER= kde@FreeBSD.org Added: head/net/messagelib/files/patch-git_347659 ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/net/messagelib/files/patch-git_347659 Wed Nov 28 21:13:54 2018 (r486149) @@ -0,0 +1,19 @@ +From 34765909cdf8e55402a8567b48fb288839c61612 Mon Sep 17 00:00:00 2001 +From: Laurent Montel +Date: Fri, 23 Nov 2018 07:37:02 +0100 +Subject: Exclude Refresh from MetaData (Not necessary) + +--- messageviewer/src/messagepartthemes/default/defaultrenderer.cpp.orig 2018-10-31 06:56:07 UTC ++++ messageviewer/src/messagepartthemes/default/defaultrenderer.cpp +@@ -308,6 +308,11 @@ QString processHtml(const QString &htmlSource, QString + return htmlSource; + } + extraHead = s.mid(startIndex + 6 , endIndex - startIndex - 6); ++ //Don't authorize to refresh content. ++ if (s.contains(QStringLiteral("http-equiv=\"REFRESH\""), Qt::CaseInsensitive)) { ++ extraHead.clear(); ++ } ++ + s = s.mid(endIndex + 7).trimmed(); + } +