From owner-freebsd-bugs@FreeBSD.ORG Mon Feb 4 01:53:04 2013 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D1522234 for ; Mon, 4 Feb 2013 01:53:04 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-x236.google.com (mail-la0-x236.google.com [IPv6:2a00:1450:4010:c03::236]) by mx1.freebsd.org (Postfix) with ESMTP id 4EB1D68F for ; Mon, 4 Feb 2013 01:53:04 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id gw10so4179342lab.13 for ; Sun, 03 Feb 2013 17:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=aYljp8f7H0Ou4W1w6VcVYYuiKWxvjTNn9WJE8qJT+FE=; b=ZSD2c8b10twCP4JE0sLUcWtOtdufdUX/vaOP7SXuzOyQzxML9swzmwIcH+hdShu0Dh Wq4mQqCVQT3I6seycVqZOndxiS8GNQxgnOgOzHONnixp2jPWhxGcA9Agm4AKLZK8t0zl gKul6veNcoDsyhW2t7Sf06y2buJ0U7Imqm/6o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=aYljp8f7H0Ou4W1w6VcVYYuiKWxvjTNn9WJE8qJT+FE=; b=KbZ0PuFiIw3lnH6nbe5pMqEJ+Yyp10nAycoM/v3DQxE0v+J1Hgwy69AD1dXo5SJ//h xDd6jkbKpg6k4IulmSxprML0YYfS7cBVZ9qll4JW1e65qC92qOkSnZSCIAOjqBqGQfkL M3MXryC94tAR5LDcjgxku1FJbD+PvTsDicwMMTBiSwFklWjq5/Aq3QbziV/Wod69yLHc 24nhXT3LQWnQJih0t82J0zYjIKgTZx8UuRcVuaJIQ4nwOXXcx4yGD1+dSdgzWdcmQPiS P226g5BnJhWAfwAQKqF9Zrmv6jl7QwdNTgn9TnHL2fAt5VRF8Aw0Wl2NKuV4KC26PKWK dpzA== X-Received: by 10.112.17.137 with SMTP id o9mr7747634lbd.15.1359942783178; Sun, 03 Feb 2013 17:53:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.91.164 with HTTP; Sun, 3 Feb 2013 17:52:32 -0800 (PST) In-Reply-To: <201302032100.r13L01PG044439@freefall.freebsd.org> References: <201302032100.r13L01PG044439@freefall.freebsd.org> From: Eitan Adler Date: Sun, 3 Feb 2013 20:52:32 -0500 Message-ID: Subject: Re: kern/175674: sem_open() should use O_EXLOCK with open() instead of a separate flock() call To: Giorgos Keramidas , Jilles Tjoelker Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkwggvS8/YaCuFn/C/cf/oSzXm7YCzJaaJw+yRlmSEz/2AgME7orjgftk0gsoEPvRyQGvgk Cc: freebsd-bugs@freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2013 01:53:04 -0000 On 3 February 2013 16:00, Giorgos Keramidas wrote: > The following reply was made to PR kern/175674; it has been noted by GNATS. > > The best way to fix this is in kern_openat() in the kernel but this > > might cause compatibility issues. > > Not sure if there would be serious compatibility problems if open() would > automatically restart instead of returning EINTR. It definitely seems a rather > intrusive change though. I can not see major application breakage should open(3) be changed. That said, I am confused by jilles' comment: http://pubs.opengroup.org/onlinepubs/000095399/functions/open.html open(3) is permitted to return EINTR. -- Eitan Adler