From owner-freebsd-arch Wed Oct 16 10: 5: 0 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44F7337B401; Wed, 16 Oct 2002 10:04:59 -0700 (PDT) Received: from swan.mail.pas.earthlink.net (swan.mail.pas.earthlink.net [207.217.120.123]) by mx1.FreeBSD.org (Postfix) with ESMTP id D887C43E8A; Wed, 16 Oct 2002 10:04:58 -0700 (PDT) (envelope-from tlambert2@mindspring.com) Received: from pool0308.cvx40-bradley.dialup.earthlink.net ([216.244.43.53] helo=mindspring.com) by swan.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 181rbC-00027m-00; Wed, 16 Oct 2002 10:04:46 -0700 Message-ID: <3DAD9BE6.530F8466@mindspring.com> Date: Wed, 16 Oct 2002 10:03:34 -0700 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Poul-Henning Kamp Cc: Bruce Evans , net@freebsd.org, arch@freebsd.org Subject: Re: cvs commit: src/sys/dev/kbd atkbdcreg.h References: <14910.1034771362@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Poul-Henning Kamp wrote: > In message <20021016221657.I5365-100000@gamplex.bde.org>, Bruce Evans writes: > >Ideally, header files wouldn't have any "variable sized structs" or > >anything else that depends on options. Core headers have to be much > >more careful about this because including an options header nested > >would break most modules and everything outside of the kernel (apart > >from the bug that modules and things outside of the kernel have no > >way to determine the correct value for the option). > > I agree. > > Suggestions for the best way of fixing "struct ipq" in ip_var.h > hereby solicited. Please use a union; things like diversion information result in other information not being used. It makes no sense to uniformly bloat all memory allocations for minority features, merely for the sake of uniformity. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message