From nobody Wed Oct 1 09:38:58 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cc8yC2LpGz69GVN; Wed, 01 Oct 2025 09:38:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cc8yB5bpZz3H69; Wed, 01 Oct 2025 09:38:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mC11aOtrStP5tUqbJoE2sTuKcBNmqntuO3RFOmMkJKg=; b=LMdzP/lXdwoNf+wRIuKRIAQJsCl3lMAa+nhLnkcCxIlZBfNoBWbuKpO3MjSEuP+yJiXOuM +19GXg+NnecfAzWFGZsmTb1uLMB3MetD/7mdsApwLIy7Uh0tGw2b27pS8pKFu1/g/HjSmn 2WHE66rWWwydOWYjQojLJ62Ja/r+iBDN2YeNEagvGpdF4qDegqD6SpAvwijoyKsEqnyxv3 30D+LoZdbEEZ2elAgsGzETI5N6EcTYiexrUIoTrAqMEM0P5RJffvwlXIADchWNBy211gaM jpwNXUn5iIL1u1UBZgWugR/6JGvFRrFTiAOkwD9luDjAGP9sTKqmMGxySBt8uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mC11aOtrStP5tUqbJoE2sTuKcBNmqntuO3RFOmMkJKg=; b=QxEkZ0ptlpfwXl6qJtE7FnpYxuUxdGemqeOYrGlzzSioTrNjii5SG7gulxBVke42mbDnX3 7V3MnSDcdI94C8YtInlZvA3laACuenYbILIUoBv5l7WRwEy7cm8VqCaiH3XZmkFa/oqy1v 45OlwVRDi9sVJYp6d3Z7ov4tTnfBi+kODe1yPGR4BBfV4vyBpZFSAYn+CpDMSx6ZFMJ/ZJ WcIad6wTopETPd5vLJ6o/wdSP2cXpODpV7DcSHgnsVxdPSeRvW5lPBjndPscu08vbYhDnh HrXNK+AuWvVUldDD4xJEb77nJysLfWZ72Gj6HDJKmiDvfra+3J4CJAxRXS39+A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759311538; a=rsa-sha256; cv=none; b=ITqNXrgGYVTKdLyJtcRv/Nzwy+ra3fokK1O/hhEsiAzBR7GviwaqLd91Zco7pHcULP4BQd oFkopsN4FzOfSAAVsafuVGWP/9cxf/rxJL1FnrbvzQ/0RShf0si4SjvTk4umOSReFoqXVZ fs5N3vyqulBA3mWKRFu1O9iGQ/j2zZsok4ZwOUWy4X0vCFalPdIejYIDuQ7FY6ZhOekSQe hotsYnJy4+DzvtrHSAQIPPMSUYhCMH6h8h6iCoRco5y8aH2hc1giCDPgvKB1kdQ7zQOIGa 96B9EVNkhor6wy4ia6daXvODynsIWeFMsKpNCfsTLO8Vlkbvz3k985ZvpAOlyA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cc8yB3yCvz2Gn; Wed, 01 Oct 2025 09:38:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5919cwDx016749; Wed, 1 Oct 2025 09:38:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5919cwYr016746; Wed, 1 Oct 2025 09:38:58 GMT (envelope-from git) Date: Wed, 1 Oct 2025 09:38:58 GMT Message-Id: <202510010938.5919cwYr016746@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: 2ae71a5e9ffb - stable/15 - ng_tty: copy to the correct mbuf List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 2ae71a5e9ffbca2b4e72c90c9bdd9e2c0b857f92 Auto-Submitted: auto-generated The branch stable/15 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=2ae71a5e9ffbca2b4e72c90c9bdd9e2c0b857f92 commit 2ae71a5e9ffbca2b4e72c90c9bdd9e2c0b857f92 Author: Ahmad Khalifa AuthorDate: 2025-09-25 16:54:28 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-01 09:37:35 +0000 ng_tty: copy to the correct mbuf memcpy should copy to the current mbuf, otherwise we're copying to the first mbuf in the chain over and over. Reported by: kevans Reviewed by: glebius MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52713 (cherry picked from commit e05521121f05a1b1e0d7c7b5fbe79f83fc303cd0) --- sys/netgraph/ng_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index c7d8a1b64eac..0e3230a66f66 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -427,7 +427,7 @@ ngt_rint_bypass(struct tty *tp, const void *buf, size_t len) for (mb = m; mb != NULL; mb = mb->m_next) { length = min(M_TRAILINGSPACE(mb), len - total); - memcpy(mtod(m, char *), (const char *)buf + total, length); + memcpy(mtod(mb, char *), (const char *)buf + total, length); mb->m_len = length; total += length; m->m_pkthdr.len += length;