From owner-cvs-all Sat Nov 9 2:13:29 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B507837B401; Sat, 9 Nov 2002 02:13:27 -0800 (PST) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C58243E77; Sat, 9 Nov 2002 02:13:24 -0800 (PST) (envelope-from ru@whale.sunbay.crimea.ua) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) by whale.sunbay.crimea.ua (8.12.6/8.12.6/Sunbay) with ESMTP id gA9ADC5V083875 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sat, 9 Nov 2002 12:13:12 +0200 (EET) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.6/8.12.6/Submit) id gA9ADC90083870; Sat, 9 Nov 2002 12:13:12 +0200 (EET) Date: Sat, 9 Nov 2002 12:13:12 +0200 From: Ruslan Ermilov To: "David O'Brien" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/secure/lib/libcrypto Makefile.inc Message-ID: <20021109101312.GA83098@sunbay.com> References: <200211081247.gA8Clpnv031449@repoman.freebsd.org> <20021108.144252.89055445.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G" Content-Disposition: inline In-Reply-To: <20021108.144252.89055445.imp@bsdimp.com> User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 08, 2002 at 02:42:52PM -0700, M. Warner Losh wrote: > In message: <200211081247.gA8Clpnv031449@repoman.freebsd.org> > Ruslan Ermilov writes: > : secure/lib/libcrypto Makefile.inc=20 > : Log: > : DON'T EVER PUT THIS BACK! > : =20 > : Pointy hat to: obrien >=20 > This commit appears to be correct from a technical point of view (we > shouldn't have -I/usr/include in our tree at all, since that breaks > cross building). Also, 1.28 diff doesn't match the commit message, so > likely was made in error. Since it likely was in error, a better > approach would be to have David back it out, or get his approval to > correct what appears to me to be a commit made in error. >=20 > However, it strikes me as being needlessly beligerent in tone. Such a > tone is not condusive to the proper functioning of the project. >=20 I wasn't in a good mood, yet it got worse when I saw my 1.5 hours of some testing work wasted due to these "style" changes. Nevertheless, this doesn't serve as an acceptable excuse to my negative behavior. Hence I publicly apologize to David. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE9zN+4Ukv4P6juNwoRAt/RAKCA4MVh7IfrcewOxELgTrbapuoNgwCeI9mz Q2RMam9+CIUDP3EZGr79QUU= =O4NP -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message