Date: Sat, 25 Jun 2011 20:55:21 +0400 From: Sergey Kandaurov <pluknet@freebsd.org> To: Jack F Vogel <jfv@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223350 - head/sys/dev/e1000 Message-ID: <BANLkTinQnaPZJxRiVGDWhaYHaAOiMP3t4w@mail.gmail.com> In-Reply-To: <201106202259.p5KMxT1h069297@svn.freebsd.org> References: <201106202259.p5KMxT1h069297@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 June 2011 02:59, Jack F Vogel <jfv@freebsd.org> wrote: > Author: jfv > Date: Mon Jun 20 22:59:29 2011 > New Revision: 223350 > URL: http://svn.freebsd.org/changeset/base/223350 > > Log: > =A0Eliminate some global tuneables in favor of adapter-specific, > =A0particular flow control and dma coalesce. Also improve the > =A0sysctl operation on those too. > > =A0Add IPv6 detection in the ioctl code, this was done for > =A0ixgbe first, carrying that over. > > =A0Add resource ability to disable particular adapter. > > =A0Add HW TSO capability so vlans can make use of TSO This change breaks LINT-NOINET amd64 and i386 builds. ixgbe is broken in the same way in r222588. Something like this should fix it (not tested). Index: sys/dev/e1000/if_igb.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/e1000/if_igb.c (revision 223490) +++ sys/dev/e1000/if_igb.c (working copy) @@ -1049,8 +1049,10 @@ ifp->if_flags |=3D IFF_UP; if (!(ifp->if_drv_flags & IFF_DRV_RUNNING)) igb_init(adapter); +#ifdef INET if (!(ifp->if_flags & IFF_NOARP)) arp_ifinit(ifp, ifa); +#endif } else #endif error =3D ether_ioctl(ifp, command, data); --=20 wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTinQnaPZJxRiVGDWhaYHaAOiMP3t4w>