From owner-svn-ports-all@freebsd.org Thu Sep 10 02:14:14 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BEC5EA01B40 for ; Thu, 10 Sep 2015 02:14:14 +0000 (UTC) (envelope-from pgollucci@p6m7g8.com) Received: from mail-ig0-f177.google.com (mail-ig0-f177.google.com [209.85.213.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 905001E64 for ; Thu, 10 Sep 2015 02:14:14 +0000 (UTC) (envelope-from pgollucci@p6m7g8.com) Received: by igbkq10 with SMTP id kq10so5485703igb.0 for ; Wed, 09 Sep 2015 19:14:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=uCPqTD5sIB0029+DazwEvrJwnQg7zjHv83KUff+5zvw=; b=HG408d89vsxAzW7MMvxlpiKk6Iar8Zs9GgRNcz2dukqoyN9rY704PQnpfwl9Eko37X 8MC8++yCCdZmNmwmIyBhHR8Ol3xt5mCVu/gF+mZ2Grd9HEBUpdiw0buYO0RN6lHxK9vE i8WbnB11NzC9kdh6S3S9Qu3WQIWS7tLI566bbUbQ2OKbWtbqTp29oo0nbDX3D5V7tszS CpIMK/WotfHqJcYWROmQJkucoPUjzz+AtnxlFnfFG9kUrSBm/WtFDjUOWY8W9KqoLp5i V89UGaazyecMCEmg4qKQRYXI7eRZjJDTdTNDyHjnMdYAbENbeNOV8tEpc0S8Xs1LGu4u 4CEg== X-Gm-Message-State: ALoCoQkL0od8utS29VKVgq0zW6XfyHLGN8ngg0rnhafM8C9rqq05VjGB7sqGbBPqBg8PbE8oJOlL MIME-Version: 1.0 X-Received: by 10.50.50.68 with SMTP id a4mr889884igo.49.1441850767955; Wed, 09 Sep 2015 19:06:07 -0700 (PDT) Received: by 10.50.195.230 with HTTP; Wed, 9 Sep 2015 19:06:07 -0700 (PDT) X-Originating-IP: [2600:1003:b02c:f837:e48b:10f3:986e:b632] In-Reply-To: References: <201509100045.t8A0jQFW087140@repo.freebsd.org> Date: Wed, 9 Sep 2015 22:06:07 -0400 Message-ID: Subject: Re: svn commit: r396547 - in head/textproc: . smi From: "Philip M. Gollucci" To: Jan Beich Cc: Jason Unovitch , "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Chris Hutchinson , "ports-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2015 02:14:14 -0000 Well gosh. I must not approve things while crszy. Thanks Jan! On Wednesday, September 9, 2015, Jan Beich wrote: > Jason Unovitch writes: > > > +post-patch: > > + ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \ > > CC is defined by default to a sane value in both GNU and BSD make. > One can do '/^CC/d' but see below for better way. > > > + -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \ > ^^^ > Typo: l .vs I. It still works because PREFIX is also passed via MAKE_ENV. > > > + -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \ > > + ${WRKSRC}/config.mk > > If possible try to avoid patching makefiles if overriding a few > variables is enough. For one, your entire post-patch can be: > > MAKE_ARGS= CC="${CC}" PREFIX="${PREFIX}" MANPREFIX="${MANPREFIX}" > -- --------------------------------------------------------------------------------- Curb: Your ride is here 4096R/D21D2752 ECDF B597 B54B 7F92 753E E0EA F699 A450 D21D 2752 Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. Director IT Operations, Curb What doesn't kill us can only make us stronger; Except it almost kills you.