Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Sep 2018 11:42:21 +0000 (UTC)
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r478788 - head/graphics/reallyslick
Message-ID:  <201809021142.w82BgL1Z041028@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tobik
Date: Sun Sep  2 11:42:21 2018
New Revision: 478788
URL: https://svnweb.freebsd.org/changeset/ports/478788

Log:
  graphis/reallyslick: Fix build with Clang 6
  
  hyperspace.cpp:387:19: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-narrowing]
          float diff[3] = {flarepos[0] - camPos[0], flarepos[1] - camPos[1], flarepos[2] - camPos[2]};
                           ^~~~~~~~~~~~~~~~~~~~~~~
  
  http://beefy11.nyi.freebsd.org/data/head-i386-default/p478276_s338342/logs/errors/reallyslick-0.9.1_20.log
  
  - Attempt build on arm* again; the error message is the same as on amd64/i386
  - Mark as LLD_UNSAFE when compiled with FREEALUT=on because of OpenAL [1]
  
  PR:		226980 [1]

Modified:
  head/graphics/reallyslick/Makefile

Modified: head/graphics/reallyslick/Makefile
==============================================================================
--- head/graphics/reallyslick/Makefile	Sun Sep  2 11:36:06 2018	(r478787)
+++ head/graphics/reallyslick/Makefile	Sun Sep  2 11:42:21 2018	(r478788)
@@ -11,16 +11,15 @@ DISTNAME=	rss-glx_${PORTVERSION}
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	OpenGL screensaver collection
 
-BROKEN_armv6=		fails to compile: hyperspace.cpp:387:19: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list
-BROKEN_armv7=		fails to compile: hyperspace.cpp:387:19: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list
-
 LIB_DEPENDS=	libMagickWand-6.so:graphics/ImageMagick \
 		libGLC.so:graphics/quesoglc
 
-USES=		gmake pathfix pkgconfig tar:bzip2 libtool
+USES=		compiler gmake pathfix pkgconfig tar:bzip2 libtool
 USE_GL=		glut
 GNU_CONFIGURE=	yes
 
+CXXFLAGS+=	${CXXFLAGS_${CHOSEN_COMPILER_TYPE}}
+CXXFLAGS_clang=	-Wno-c++11-narrowing
 CPPFLAGS+=	-I${LOCALBASE}/include
 LIBS+=		-L${LOCALBASE}/lib -lXext
 
@@ -29,6 +28,7 @@ OPTIONS_DEFINE=	FREEALUT GLEW
 FREEALUT_DESC=	Enable freealut support
 FREEALUT_CONFIGURE_ENABLE=	sound
 FREEALUT_USES=	openal:alut
+FREEALUT_VARS=	LLD_UNSAFE=yes # cf. PR 226980
 
 GLEW_DESC=	Enable GLEW support
 GLEW_USE=	GL=glew



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809021142.w82BgL1Z041028>