Date: Sat, 15 Jun 2002 20:50:54 -0500 From: Ade Lovett <ade@FreeBSD.org> To: Doug Barton <DougB@FreeBSD.org> Cc: Akinori MUSHA <knu@iDaemons.org>, Trevor Johnson <trevor@jpj.net>, Mikhail Teterin <mi+mx@aldan.algebra.com>, Pete Fritchman <petef@absolutbsd.org>, <portmgr@FreeBSD.org>, Maxim Sobolev <sobomax@FreeBSD.org>, <ports@FreeBSD.org>, <jmallett@FreeBSD.org> Subject: Re: REINPLACE Message-ID: <B931592E.11EA7%ade@FreeBSD.org> In-Reply-To: <20020614160259.O85459-100000@12-234-22-238.client.attbi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/14/02 18:15, "Doug Barton" <DougB@FreeBSD.org> wrote:
> At tremendous risk to my sanity, I'm going to try and make a rather
> obvious point one more time. You guys are putting a tremendous amount of
> effort into this REINPLACE stuff in order to avoid the simple, clean
> solution of not doing the patching 'in place' at all. I have the following
> (or something similar) in several of my ports:
>
> post-patch:
> @ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
> @ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
> ${WRKSRC}/configure.Patched > ${WRKSRC}/configure
Two things:
doesn't take into account multiple files (for-loop or xargs)
leaves *.Patched turds lying around, which may cause PLIST breakage
-aDe
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B931592E.11EA7%ade>