From owner-freebsd-bugs  Fri Apr 30 15:20: 4 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 17C7A14EB7
	for <freebsd-bugs@FreeBSD.org>; Fri, 30 Apr 1999 15:20:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id PAA89802;
	Fri, 30 Apr 1999 15:20:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id AB79814EB7; Fri, 30 Apr 1999 15:19:03 -0700 (PDT)
Message-Id: <19990430221903.AB79814EB7@hub.freebsd.org>
Date: Fri, 30 Apr 1999 15:19:03 -0700 (PDT)
From: cpeterso@cs.washington.edu
To: freebsd-gnats-submit@freebsd.org
X-Send-Pr-Version: www-1.0
Subject: kern/11410: code typo in ad1848.c: the != operator has higher precedence than the & operator. 
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         11410
>Category:       kern
>Synopsis:       code typo in ad1848.c: the != operator has higher precedence than the & operator.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 30 15:20:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Christopher Peterson
>Release:        FreeBSD 3.1-RELEASE i386
>Organization:
>Environment:
>Description:

i386/isa/snd/ad1848.c (line 2039):	& XXX == ; 8:
		if (inb(ad1816_int(d)) & AD1816_INTRPI != 0)

The != operator has higher precedence than the & operator. Therefore 
the above line is actually compiled as:
     if (inb(ad1816_int(d)) & (AD1816_INTRPI != 0) )

but the author probably meant:
     if ( (inb(ad1816_int(d)) & AD1816_INTRPI) != 0)


>How-To-Repeat:

>Fix:

     if ( (inb(ad1816_int(d)) & AD1816_INTRPI) != 0)


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message