From owner-freebsd-bugs@freebsd.org  Tue Apr  5 23:21:32 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 511CFB043CB
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue,  5 Apr 2016 23:21:32 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3A0571741
 for <freebsd-bugs@FreeBSD.org>; Tue,  5 Apr 2016 23:21:32 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u35NLWrm080721
 for <freebsd-bugs@FreeBSD.org>; Tue, 5 Apr 2016 23:21:32 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 207786] gpioiic_callback() dereferences IIC "how" argument
 incorrectly
Date: Tue, 05 Apr 2016 23:21:32 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: chadf@triularity.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-207786-8-TyXCDUl3I4@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-207786-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-207786-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Apr 2016 23:21:32 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207786

--- Comment #2 from chadf@triularity.org ---
When will anyone ever pass an address that isn't memory aligned _and_ using=
 the
interface correctly? Any code calling that which doesn't pass the address o=
f an
int (which should be aligned automatically) should be fixed instead of tryi=
ng
to work around it here.

The only place in the sys code that seems to initiate such a callback (for
IIC_REQUEST_BUS) is iicbus_request_bus() [sys/dev/iicbus/iiconf.c], which
passes the address of an int parameter that is expected to already be align=
ed.

The function lpbb_callback() [sys/dev/ppbus/lpbb.c] already handles this
properly, presumable without any alignment problems.

--=20
You are receiving this mail because:
You are the assignee for the bug.=