From owner-svn-src-all@freebsd.org Sun Nov 1 15:57:15 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 44DD7451058; Sun, 1 Nov 2020 15:57:15 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CPLK715TDz4HYX; Sun, 1 Nov 2020 15:57:15 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 047D51ACC2; Sun, 1 Nov 2020 15:57:15 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 0A1FvEc2003838; Sun, 1 Nov 2020 15:57:14 GMT (envelope-from adrian@FreeBSD.org) Received: (from adrian@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 0A1FvE0v003837; Sun, 1 Nov 2020 15:57:14 GMT (envelope-from adrian@FreeBSD.org) Message-Id: <202011011557.0A1FvE0v003837@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: adrian set sender to adrian@FreeBSD.org using -f From: Adrian Chadd Date: Sun, 1 Nov 2020 15:57:14 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r367248 - head/usr.bin/iscsictl X-SVN-Group: head X-SVN-Commit-Author: adrian X-SVN-Commit-Paths: head/usr.bin/iscsictl X-SVN-Commit-Revision: 367248 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2020 15:57:15 -0000 Author: adrian Date: Sun Nov 1 15:57:14 2020 New Revision: 367248 URL: https://svnweb.freebsd.org/changeset/base/367248 Log: [iscsictl] Fix compile issues that creep up with gcc-6.4 This fixes two warnings: * double-definition of a symbol in a yacc header * Comparison of an unsigned int being >= 0; that's always going to be true. Reviewed by: imp, rscheff Differential Revision: https://reviews.freebsd.org/D27036 Modified: head/usr.bin/iscsictl/parse.y Modified: head/usr.bin/iscsictl/parse.y ============================================================================== --- head/usr.bin/iscsictl/parse.y Sun Nov 1 11:34:15 2020 (r367247) +++ head/usr.bin/iscsictl/parse.y Sun Nov 1 15:57:14 2020 (r367248) @@ -54,7 +54,6 @@ static struct conf *conf; static struct target *target; extern void yyerror(const char *); -extern int yylex(void); extern void yyrestart(FILE *); %} @@ -359,7 +358,7 @@ pcp: PCP EQUALS STR free($3); return(1); } - if (!((tmp >=0) && (tmp <= 7))) { + if (tmp > 7) { yyerror("invalid pcp value"); return(1); }