From owner-svn-ports-head@freebsd.org Wed Sep 14 22:01:42 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1BF3BDA279; Wed, 14 Sep 2016 22:01:42 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 893781D05; Wed, 14 Sep 2016 22:01:41 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [127.0.0.1] (ip70-178-28-115.ks.ks.cox.net [70.178.28.115]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 5517C43CC0; Wed, 14 Sep 2016 17:01:36 -0500 (CDT) Subject: Re: svn commit: r422160 - in head: chinese/fortune french/fortune-mod-zarathoustra misc/fortune-mod-bible misc/fortune-mod-bofh misc/fortune-mod-culmea-culmilor misc/fortune-mod-epictetus misc/fortune-... To: Steve Wills , marino@freebsd.org, Mathieu Arnold , Adam Weinberger , Antoine Brodin References: <201609141950.u8EJolO7085386@repo.freebsd.org> <857FD0DF-6ADA-48F5-B02B-81BCA7135E2C@adamw.org> <03e06c33-6185-334f-bf04-71321aaf2cb7@FreeBSD.org> <9ffe58d7-66b0-b357-1777-6e4d3d4f5297@marino.st> <9d118285-dd65-0b88-59cd-c8130d4d4f6f@marino.st> <087264b0-36ab-e844-f2f9-8389566dd654@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org From: John Marino Message-ID: <55840821-5f88-54b6-4b99-eb8e09d0ae22@marino.st> Date: Wed, 14 Sep 2016 17:01:38 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <087264b0-36ab-e844-f2f9-8389566dd654@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 160914-2, 09/14/2016), Outbound message X-Antivirus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2016 22:01:42 -0000 On 9/14/2016 16:55, Steve Wills wrote: > On 09/14/2016 17:28, John Marino wrote: >> The fact is that the scenario above is legitimate and it was fixed. > > I'm not sure I agree. There are exceptions, but ports hasn't typically > accommodated all the things that can be disabled in base. > > Looks like there are 179 WITHOUT_* knobs. I'm probably missing > something, but it looks like ports only currently accommodates > WITHOUT_NLS and WITHOUT_SSP. Not all of the WITHOUT_* knobs would affect > ports, but adding support for all the WITHOUT_* knobs would still be a > big decision and a big job. Adding support for WITHOUT_GAMES would have > been different from what was done. > Fact 1) I identified it as a problem Fact 2) I solved the problem. The ports were cleaner as a result. Fact 3) Somebody exerted energy to revert my work There are over 26,000 ports. This one should have caused no one to notice. Half of the fortune ports are currently marked broken because they are unfetchable. Even if you disagree for whatever reason, at *worst* it wasn't hurting anything. The insult to injury it that this stuff was pulled immediately after I spent several days fixing SSL across the entire tree. Trust me, I'm pretty ticked off right now and it is personal for me. John --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus