Date: Fri, 19 Jan 2018 11:54:08 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: Emmanuel Vadot <manu@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r328129 - head/sys/fs/nfsserver Message-ID: <20180119115408.f333d3a6ec8d762e73f1d844@bidouilliste.com> In-Reply-To: <YTXPR0101MB21741F3254BD5F9381B42DBADDE80@YTXPR0101MB2174.CANPRD01.PROD.OUTLOOK.COM> References: <201801181528.w0IFSnWm053535@repo.freebsd.org> <20180118163855.b0a55427709c52d0ec2482c9@bidouilliste.com> <YTXPR0101MB21741F3254BD5F9381B42DBADDE80@YTXPR0101MB2174.CANPRD01.PROD.OUTLOOK.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 18 Jan 2018 22:15:16 +0000 Rick Macklem <rmacklem@uoguelph.ca> wrote: > Emmanuel Vadot wrote: > >> Author: manu > >> Date: Thu Jan 18 15:28:49 2018 > >> New Revision: 328129 > >> URL: https://svnweb.freebsd.org/changeset/base/328129 > >> > >> Log: > >> nfs: Do not printf each time a lock structure is freed during module unload > >> > >> There can be a lot of those structures and printing a line each time we free > >> one on module unload. > > > > Finishing the sentence : > > > > There can be a lot of those structures and printing a line each time > >we free one on module unload is really time consuming, especially when > >you have a serial console plugged in. > > I will note that when I put a printf() like this in the code, it is because I > consider it an abnormal occurrence. It might be better to at least print > the message once. So should we warn once or maybe return EBUSY on unloading if there is still lock structures ? > For this case, normally all lock structures should go away when clients > unmount and unloading the nfsd module while there are active mounts > is not a safe practice. (Again NFSv4 isn't like NFSv3, there is server state > for NFSv4.) > > rick -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180119115408.f333d3a6ec8d762e73f1d844>