From owner-cvs-all  Sat May 11 15:55:38 2002
Delivered-To: cvs-all@freebsd.org
Received: from fw.wemm.org (12-232-135-171.client.attbi.com [12.232.135.171])
	by hub.freebsd.org (Postfix) with ESMTP
	id 70A4D37B401; Sat, 11 May 2002 15:55:33 -0700 (PDT)
Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3])
	by fw.wemm.org (8.11.6/8.11.6) with ESMTP id g4BMtX450271;
	Sat, 11 May 2002 15:55:33 -0700 (PDT)
	(envelope-from peter@wemm.org)
Received: from wemm.org (localhost [127.0.0.1])
	by overcee.wemm.org (Postfix) with ESMTP
	id E99C13809; Sat, 11 May 2002 15:55:32 -0700 (PDT)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4
To: "Jacques A. Vidrine" <nectar@FreeBSD.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, re@FreeBSD.org
Subject: Re: cvs commit: src/kerberos5/usr.bin/k5su Makefile 
In-Reply-To: <20020511223056.GA60845@madman.nectar.cc> 
Date: Sat, 11 May 2002 15:55:32 -0700
From: Peter Wemm <peter@wemm.org>
Message-Id: <20020511225532.E99C13809@overcee.wemm.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

"Jacques A. Vidrine" wrote:
> On Sat, May 11, 2002 at 01:28:37PM -0700, Peter Wemm wrote:
> > Jacques Vidrine wrote:
> > > nectar      2002/05/11 08:35:12 PDT
> > > 
> > >   Modified files:        (Branch: RELENG_4)
> > >     kerberos5/usr.bin/k5su Makefile 
> > >   Log:
> > >   MFC 1.5: Do not install this with set-user-ID bit set.
> > 
> > This is going to be fun on the FreeBSD.org cluster.  Where is the
> > override?
> 
> There isn't one.  Feel free to add one (default to no set-user-ID) if
> you need it.

This is not acceptable.  You are breaking existing systems, for example,
the *.freebsd.org cluster.

I have formally complained to re@ about this MFC.

If you are going to do this, do it right.  Put a #if 0 around the fallback
code that looks up the plaintext passwords or something.  Do not screw up
the whole tool.  Even more inexcusable is that you are clobbering a working
/usr/bin/k5su with a non-working one.

Cheers,
-Peter


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message