From owner-cvs-all Sat Jan 11 23:50:44 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 363E637B401; Sat, 11 Jan 2003 23:50:43 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4B2243F5F; Sat, 11 Jan 2003 23:50:42 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 97948AE2BE; Sat, 11 Jan 2003 23:50:42 -0800 (PST) Date: Sat, 11 Jan 2003 23:50:42 -0800 From: Alfred Perlstein To: Jake Burkholder Cc: Matthew Dillon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... Message-ID: <20030112075042.GE33821@elvis.mu.org> References: <200301120137.h0C1bD0E098037@repoman.freebsd.org> <20030111213259.E212@locore.ca> <200301120254.h0C2srcS043241@apollo.backplane.com> <20030112014644.F212@locore.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030112014644.F212@locore.ca> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Jake Burkholder [030111 22:46] wrote: > > Its unnecessary code churn. I wouldn't be surprised if struct file was > used all the place in 3rd party modules, especially MAC modules. Now > they either need an ugly compat define or ugly idfefs. Some of your commits > were to code that's externally maintained. We've broken compatibility with > external code before for compelling reasons. This is not a compelling reason. > > You obviously don't think this is important, I do. If no one else cares about > this I'll shut up now. I prefer Jake's idea of just removing the casts where they are unneeded. This adds unneeded complexity and renaming that we don't need. It also reduces diffs to what will be 5-stable. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message