Date: Fri, 07 Dec 2018 19:21:37 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 233849] [PATCH] r339008 broke repquota on UFS Message-ID: <bug-233849-3630-I1v5h8ZVTS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233849-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-233849-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233849 --- Comment #3 from Sean Eric Fagan <sef@FreeBSD.org> --- ok. repquota is going through and reading the quoata file. Which it can o= nly do on UFS. There is, as far as I can tell, no problem with checking hasquota() first, although if it returns no error, then there's no reason to call quotactl() afterwards, I think. This means the code should be moved around and refactored a bit to get the tests done in the right way -- namely, only call quotactl() if hasquota() fails, but fail if quotactl() fails, but also if hasquota() succeeds but it= 's not UFS. (For now, anyway.) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233849-3630-I1v5h8ZVTS>