From owner-freebsd-hackers@freebsd.org Wed Feb 21 03:27:40 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EF23F25C1B for ; Wed, 21 Feb 2018 03:27:40 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7572E81A18 for ; Wed, 21 Feb 2018 03:27:37 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.15.2/8.15.2) with ESMTPS id w1L3Mn1j081693 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 21 Feb 2018 11:22:50 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.15.2/8.15.2/Submit) id w1L3MlsG081692; Wed, 21 Feb 2018 11:22:47 +0800 (CST) (envelope-from kevlo) Date: Wed, 21 Feb 2018 11:22:47 +0800 From: Kevin Lo To: Eitan Adler Cc: FreeBSD Hackers , Warner Losh Subject: Re: Marking select(2) as restrict Message-ID: <20180221032247.GA81670@ns.kevlo.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 03:27:40 -0000 On Tue, Feb 20, 2018 at 04:29:59PM -0800, Eitan Adler wrote: > > I filed a request for a slightly modified version of this patch to be > exp-run. I'm planning on committing unless there is significant > fallout or objections on this list. > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225981 Please send your patch to standards@. The freebsd-standards mailing list was created for precisely this purpose, thanks. > On 15 February 2018 at 00:10, Eitan Adler wrote: > > Hi all, > > > > POSIX requires that the fd_set arguments in select(2) be marked as > > restrict. This patch attempts to implement that. > > > > (a) Am I missing anything? > > (b) Anything in particular to watch out for? > > (c) Assuming an exp-run passes any reason not to commit? > > > > > > Index: lib/libc/sys/select.2 > > =================================================================== > > --- lib/libc/sys/select.2 (revision 329296) > > +++ lib/libc/sys/select.2 (working copy) > > @@ -39,7 +39,7 @@ > > .Sh SYNOPSIS > > .In sys/select.h > > .Ft int > > -.Fn select "int nfds" "fd_set *readfds" "fd_set *writefds" "fd_set > > *exceptfds" "struct timeval *timeout" > > +.Fn select "int nfds" "fd_set * restrict readfds" "fd_set * restrict > > writefds" "fd_set * restrict exceptfds" "struct timeval *timeout" > > .Fn FD_SET fd &fdset > > .Fn FD_CLR fd &fdset > > .Fn FD_ISSET fd &fdset > > Index: lib/libc/sys/select.c > > =================================================================== > > --- lib/libc/sys/select.c (revision 329296) > > +++ lib/libc/sys/select.c (working copy) > > @@ -41,7 +41,7 @@ __weak_reference(__sys_select, __select); > > > > #pragma weak select > > int > > -select(int n, fd_set *rs, fd_set *ws, fd_set *es, struct timeval *t) > > +select(int n, fd_set * restrict rs, fd_set * restrict ws, fd_set * > > restrict es, struct timeval *t) > > { > > > > return (((int (*)(int, fd_set *, fd_set *, fd_set *, struct timeval *)) > > Index: sys/sys/select.h > > =================================================================== > > --- sys/sys/select.h (revision 329296) > > +++ sys/sys/select.h (working copy) > > @@ -101,8 +101,7 @@ int pselect(int, fd_set *__restrict, fd_set *__res > > const struct timespec *__restrict, const sigset_t *__restrict); > > #ifndef _SELECT_DECLARED > > #define _SELECT_DECLARED > > -/* XXX missing restrict type-qualifier */ > > -int select(int, fd_set *, fd_set *, fd_set *, struct timeval *); > > +int select(int, fd_set *__restrict, fd_set *__restrict, fd_set > > *__restrict, struct timeval *); > > #endif > > __END_DECLS > > #endif /* !_KERNEL */ > > > > > > -- > > Eitan Adler > > > > -- > Eitan Adler > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" >