Date: Fri, 05 Sep 2014 05:50:50 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193304] [maintainer] update ports-mgmt/pkg_replace (more compatible "portupgrade") Message-ID: <bug-193304-13-BVejhIuM4i@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193304-13@https.bugs.freebsd.org/bugzilla/> References: <bug-193304-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193304 --- Comment #4 from John Marino <marino@FreeBSD.org> --- This is really close, but it needs one more iteration. minor: You need to actually remove all the lines after "WWW: ..." on pkg-descr. The package descriptions no longer reflect authors, maintainers, etc. This is true across the tree and if seen those are removed when the port is update. issue: You used PLIST_FILES which is good, but you didn't use PLIST_DIRS or PLIST_DIRSTRY. see https://www.freebsd.org/doc/en/books/porters-handbook/plist.html Can you fix that? preference: Can you change this: +.for i in ${PORTDOCS} + ${INSTALL_DATA} ${WRKSRC}/${i} \ + ${STAGEDIR}${DOCSDIR}/ +.endfor to + (cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR}) What you had worked but I don't like unnecessary loops. And test that your change works. Everything else looks fine. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193304-13-BVejhIuM4i>