From owner-freebsd-net@FreeBSD.ORG Thu Jun 9 22:10:13 2005 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 01E1316A41C for ; Thu, 9 Jun 2005 22:10:13 +0000 (GMT) (envelope-from vladgalu@gmail.com) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90CD443D4C for ; Thu, 9 Jun 2005 22:10:12 +0000 (GMT) (envelope-from vladgalu@gmail.com) Received: by zproxy.gmail.com with SMTP id 9so385687nzo for ; Thu, 09 Jun 2005 15:10:11 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Mr6oUfqzLFEeY/3sv9sHSjTTPiOhzpJvzY2AmbYNbxMITig0JmQVIBB28T2K5diClY4AayAP2UOD07ZHqRatY93Tfd3JWfqf6bsVou9Tyo96jxJdConTOq000WQLk/smZ73Sbf0Y/NwcrTmhNZgKbyYOd+O95f2hyjeqGgC3qN8= Received: by 10.36.34.2 with SMTP id h2mr710951nzh; Thu, 09 Jun 2005 15:10:11 -0700 (PDT) Received: by 10.36.86.4 with HTTP; Thu, 9 Jun 2005 15:10:11 -0700 (PDT) Message-ID: <79722fad050609151068c71c91@mail.gmail.com> Date: Fri, 10 Jun 2005 01:10:11 +0300 From: Vlad GALU To: freebsd-pf@freebsd.org, freebsd-net@freebsd.org In-Reply-To: <79722fad05060914123edd1004@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <79722fad05060914123edd1004@mail.gmail.com> Cc: Subject: Re: Please review & test this X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Vlad GALU List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2005 22:10:13 -0000 On 6/10/05, Vlad GALU wrote: > As you may all know, the packet classifier in ALTQ is very > slow on large numbers of classes, because it stores them linearly, in > an array. I rewrote the way classes are stored, replacing the array > with a hash table. I tested [1] on a system with about 8000 classes > and noticed a remarkable performance difference (the system went from > almost unusable to nice & smooth). It breaks the ABI by adding an > extra TAILQ_ENTRY member to the HFSC class structure, though.=20 And also replaces the class array in struct hfsc_if with the hash table. > If anyone reviews and tests it, I would be grateful. >=20 > [1] http://night.rdslink.ro/dudu/altq/altq_hfschash.diff >=20 > P.S. please keep in mind that I'm not exactly a black belt in kernel > programming, so glitches might exist. I would be most happy to hear > some suggestions. >=20 > -- > If it's there, and you can see it, it's real. > If it's not there, and you can see it, it's virtual. > If it's there, and you can't see it, it's transparent. > If it's not there, and you can't see it, you erased it. >=20 --=20 If it's there, and you can see it, it's real. If it's not there, and you can see it, it's virtual. If it's there, and you can't see it, it's transparent. If it's not there, and you can't see it, you erased it.