From owner-svn-ports-all@freebsd.org Wed Feb 3 09:11:06 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2819A76CDC; Wed, 3 Feb 2016 09:11:06 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from mail.madpilot.net (grunt.madpilot.net [78.47.145.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 775311315; Wed, 3 Feb 2016 09:11:05 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from mail (mail [192.168.254.3]) by mail.madpilot.net (Postfix) with ESMTP id 3pwHLH3vMhzZrb; Wed, 3 Feb 2016 10:11:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= content-transfer-encoding:content-type:content-type:in-reply-to :mime-version:user-agent:date:date:message-id:from:from :references:subject:subject:received:received; s=mail; t= 1454490661; x=1456305062; bh=znySx70F506ex/+O3QY4Kl/dv9jwAJ0o+ek f08Iimeg=; b=TIEKP8SLfnarCb+5JRePlN5oMPGe4xdE3rZq1WHx+wOWsJGQEP5 tGwN2HgZjAgRAk5gpOxE3JopNdtsPts4ClV2lO37IaGUDCcKGT1DHd9Rb9W7XFQ2 FdUoiyzhdr0fHdtGKEVsG7jT+C9XAaoHpQ4i5AR/kf6l2lWM1pCfDJmE= Received: from mail.madpilot.net ([192.168.254.3]) by mail (mail.madpilot.net [192.168.254.3]) (amavisd-new, port 10024) with ESMTP id zpIS6JyqAp6o; Wed, 3 Feb 2016 10:11:01 +0100 (CET) Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206]) by mail.madpilot.net (Postfix) with ESMTPSA; Wed, 3 Feb 2016 10:11:01 +0100 (CET) Subject: Re: svn commit: r407901 - in head/net-mgmt/collectd5: . files To: Alexey Dokuchaev References: <201602022308.u12N8kud098510@repo.freebsd.org> <20160203065658.GA77151@FreeBSD.org> <56B1BFBD.7030301@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Guido Falsi Message-ID: <56B1C425.5090407@madpilot.net> Date: Wed, 3 Feb 2016 10:11:01 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56B1BFBD.7030301@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 09:11:06 -0000 On 02/03/16 09:52, Guido Falsi wrote: > On 02/03/16 07:56, Alexey Dokuchaev wrote: >> On Tue, Feb 02, 2016 at 11:08:46PM +0000, Guido Falsi wrote: >>> New Revision: 407901 >>> URL: https://svnweb.freebsd.org/changeset/ports/407901 >>> >>> Log: >>> - Update to 5.5.1 >>> - Mark MONGODB option as BROKEN >> >> Commit log does not explain what's exactly broken, which makes it (the log) >> pretty useless. :( > > That information is in the PR, which is referenced by the commit > message, I thought that could be enough. > >> >>> +1,032 -2 head/net-mgmt/collectd5/files/patch-src__Makefile.in >> >> This huge patch suggests that it's probably better to patch Makefile.am and >> regenerate Makefile.in instead. > > I must admit I'm not an expert with the autotools so I took the > submitter's work for granted as long as it worked. > > I can try to fix this by working with him and see if we can get a better > patch. > Some further analysis shows that the port is already regenerating the .in files, most probably this patch slipped into the diff by mistake, I should have caught this. Sorry for the mistake, I'm making sure everything works fine without it and will commit a fix once sure. Thanks for reporting. -- Guido Falsi