From owner-cvs-src@FreeBSD.ORG Mon Nov 3 11:04:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B824616A4CF; Mon, 3 Nov 2003 11:04:09 -0800 (PST) Received: from newman.gte.com (newman.gte.com [132.197.8.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id C073343FD7; Mon, 3 Nov 2003 11:03:47 -0800 (PST) (envelope-from ak03@gte.com) Received: from h132-197-179-27.gte.com ([132.197.179.27]) by newman.gte.com (8.9.1/8.9.1) with ESMTP id OAA28774; Mon, 3 Nov 2003 14:03:47 -0500 (EST) Received: from kanpc.gte.com (localhost [IPv6:::1])hA3J3kYU001131; Mon, 3 Nov 2003 14:03:46 -0500 (EST) (envelope-from ak03@gte.com) Date: Mon, 3 Nov 2003 14:03:46 -0500 From: Alexander Kabaev To: Alfred Perlstein Message-Id: <20031103140346.54afab43.ak03@gte.com> In-Reply-To: <20031103185522.GE47459@elvis.mu.org> References: <200311030446.hA34kJl5078327@repoman.freebsd.org> <20031103185522.GE47459@elvis.mu.org> Organization: Verizon Data Services X-Mailer: Sylpheed version 0.9.6claws65 (GTK+ 1.2.10; i386-portbld-freebsd5.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: Alexander Kabaev cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/gnu/ext2fs ext2_vfsops.c src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2003 19:04:10 -0000 On Mon, 3 Nov 2003 10:55:22 -0800 Alfred Perlstein wrote: > * Alexander Kabaev [031102 20:46] wrote: > > kan 2003/11/02 20:46:19 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/gnu/ext2fs ext2_vfsops.c > > sys/ufs/ffs ffs_vfsops.c > > Log: > > Use VOP_UNLOCK/vrele instead of vput. td was erecived as a > > parameter and one cannot be sure it is equal to curthread. > > If there is one place (boot()) where this isn't the case, can't that > place be fixed? My guess is that a lot of other stuff breaks when > the thread vop parameter isn't curthread in other cases. > There is a number of issues with fixing sync to pass a real curthread and Bruce listed them in his email. Going forward, I think we should strip 'td' parameters from VOPs altogether, but I think this is a 6.0 material. -- Alexander Kabaev