From owner-cvs-src@FreeBSD.ORG Mon Jul 14 13:14:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C0F0A37B401; Mon, 14 Jul 2003 13:14:17 -0700 (PDT) Received: from srv1.cosmo-project.de (srv1.cosmo-project.de [213.83.6.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0093043F85; Mon, 14 Jul 2003 13:14:16 -0700 (PDT) (envelope-from ticso@cicely12.cicely.de) Received: from cicely5.cicely.de (cicely5.cicely.de [IPv6:3ffe:400:8d0:301:200:92ff:fe9b:20e7]) by srv1.cosmo-project.de (8.12.9/8.12.9) with ESMTP id h6EKEChR078834 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Mon, 14 Jul 2003 22:14:14 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (cicely12.cicely.de [IPv6:3ffe:400:8d0:301::12]) by cicely5.cicely.de (8.12.9/8.12.9) with ESMTP id h6EKEBAx007969 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Jul 2003 22:14:11 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (localhost [127.0.0.1]) by cicely12.cicely.de (8.12.9/8.12.9) with ESMTP id h6EKEAgt089012; Mon, 14 Jul 2003 22:14:10 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: (from ticso@localhost) by cicely12.cicely.de (8.12.9/8.12.9/Submit) id h6EKEA1k089008; Mon, 14 Jul 2003 22:14:10 +0200 (CEST) Date: Mon, 14 Jul 2003 22:14:09 +0200 From: Bernd Walter To: Josef Karthauser Message-ID: <20030714201409.GO72706@cicely12.cicely.de> References: <200307141746.h6EHkRjh079950@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307141746.h6EHkRjh079950@repoman.freebsd.org> X-Operating-System: FreeBSD cicely12.cicely.de 5.1-CURRENT alpha User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb uhub.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: ticso@cicely.de List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2003 20:14:18 -0000 On Mon, Jul 14, 2003 at 10:46:27AM -0700, Josef Karthauser wrote: > joe 2003/07/14 10:46:27 PDT > > FreeBSD src repository > > Modified files: > sys/dev/usb uhub.c > Log: > As defined by USB Specification Rev 2.0 (in section 11.24.2.5), to > get a Hub descriptor, we have to set req.wValue to "Descriptor Type > and Descriptor Index". In this case, Descriptor Type is 0x29 > (UDESC_HUB), Descriptor Index should be 0. > > If I don't do a check (dev->address > 1 ... ), root hub fails. > > A new Cytronix 4-port USB 2.0 Hub (Cypress CY7C65640 chip) now works > after this patch. Interesting - I'm running a CY7C65640 based hub since a while without problems. Which revision was it - mine is the following: port 1 addr 6: full speed, self powered, config 1, product 0x6560(0x6560), Cypress Semiconductor(0x04b4), rev 0.07 -- B.Walter BWCT http://www.bwct.de ticso@bwct.de info@bwct.de