From owner-freebsd-current@FreeBSD.ORG Fri Aug 20 01:04:40 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15ADE16A4CE for ; Fri, 20 Aug 2004 01:04:40 +0000 (GMT) Received: from ms-dienst.rz.rwth-aachen.de (ms-2.rz.RWTH-Aachen.DE [134.130.3.131]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6ADA43D2D for ; Fri, 20 Aug 2004 01:04:39 +0000 (GMT) (envelope-from chris@unixpages.org) Received: from r220-1 (r220-1.rz.RWTH-Aachen.DE [134.130.3.31]) by ms-dienst.rz.rwth-aachen.de (iPlanet Messaging Server 5.2 HotFix 1.12 (built Feb 13 2003)) with ESMTP id <0I2Q007NC0BQTR@ms-dienst.rz.rwth-aachen.de> for current@freebsd.org; Fri, 20 Aug 2004 03:04:38 +0200 (MEST) Received: from relay.rwth-aachen.de ([134.130.3.1]) by r220-1 (MailMonitor for SMTP v1.2.2 ) ; Fri, 20 Aug 2004 03:04:38 +0200 (MEST) Received: from haakonia.hitnet.rwth-aachen.de (haakonia.hitnet.RWTH-Aachen.DE [137.226.181.92])i7K14bRA014982; Fri, 20 Aug 2004 03:04:37 +0200 (MEST) Received: from gondor.middleearth (gondor.middleearth [192.168.1.42]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))(Postfix) with ESMTP id 4C7B928468; Fri, 20 Aug 2004 03:04:32 +0200 (CEST) Received: by gondor.middleearth (Postfix, from userid 1001) id 087DF613A; Fri, 20 Aug 2004 03:04:32 +0200 (CEST) Date: Fri, 20 Aug 2004 03:04:31 +0200 From: Christian Brueffer In-reply-to: <2711.1092950127@critter.freebsd.dk> To: Poul-Henning Kamp Message-id: <20040820010431.GD12219@unixpages.org> MIME-version: 1.0 Content-type: multipart/signed; boundary=RhUH2Ysw6aD5utA4; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-disposition: inline User-Agent: Mutt/1.5.5.1i X-Operating-System: FreeBSD 5.2-CURRENT X-PGP-Key: http://people.freebsd.org/~brueffer/brueffer.key.asc X-PGP-Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D References: <20040819211141.GA12219@unixpages.org> <2711.1092950127@critter.freebsd.dk> cc: current@freebsd.org Subject: Re: [REVIEW/TEST] Rewritten floppy driver. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2004 01:04:40 -0000 --RhUH2Ysw6aD5utA4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 19, 2004 at 11:15:27PM +0200, Poul-Henning Kamp wrote: > In message <20040819211141.GA12219@unixpages.org>, Christian Brueffer wri= tes: > > > >--k+w/mQv8wyuph6w0 > >Content-Type: text/plain; charset=3Dus-ascii > >Content-Disposition: inline > >Content-Transfer-Encoding: quoted-printable > > > >On Thu, Aug 19, 2004 at 03:43:07PM +0200, Poul-Henning Kamp wrote: > >>=3D20 > >> Please review and test this patch: > >>=3D20 > >> http://phk.freebsd.dk/patch/fdc.patch > >>=3D20 > > > >The patch works for me, except mounting a write protected disk read-only: > > > >haakonia# mount -t msdosfs -r /dev/fd0 /mnt/private/ > >msdosfs: /dev/fd0: Read-only file system >=20 > This is a bug elsewhere and it is fixed on my "phk_bufwork" branch > which will arrive in -current in about a month or so. >=20 I just noticed, that the patch breaks world: cc -O -pipe -g -march=3Dpentium -I/usr/home/build/src/usr.sbin/fdcontrol/../fdread -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -c /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c: In function `main': /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error: `FD_DEBUG' undeclared (first use in this function) /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error: (Each undeclared identifier is reported only once /usr/home/build/src/usr.sbin/fdcontrol/fdcontrol.c:212: error: for each function it appears in.) *** Error code 1 Stop in /usr/home/build/src/usr.sbin/fdcontrol. *** Error code 1 Stop in /usr/home/build/src/usr.sbin. *** Error code 1 Stop in /usr/home/build/src. *** Error code 1 Stop in /usr/home/build/src. *** Error code 1 Stop in /usr/home/build/src. haakonia# - Christian --=20 Christian Brueffer chris@unixpages.org brueffer@FreeBSD.org GPG Key: http://people.freebsd.org/~brueffer/brueffer.key.asc GPG Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D --RhUH2Ysw6aD5utA4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBJU4fbHYXjKDtmC0RAge5AJ9bhkL08MjZE9EWzMZKorEr4PXEIgCggvEq 2JNIu7QNm33XBmM2GaxpSiE= =kLIK -----END PGP SIGNATURE----- --RhUH2Ysw6aD5utA4--