Date: Wed, 9 Sep 2015 22:17:23 -0400 From: Jason Unovitch <jason.unovitch@gmail.com> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: Jan Beich <jbeich@freebsd.org>, Jason Unovitch <junovitch@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Chris Hutchinson <portmaster@bsdforge.com>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r396547 - in head/textproc: . smi Message-ID: <20150910021723.GA7969@Silverstone.nc-us.unovitch.com> In-Reply-To: <CACM2dAaD=7uqRN89E2d1=t7yCR3GzDCy8TiB-CX1J6g2D8QD1w@mail.gmail.com> References: <201509100045.t8A0jQFW087140@repo.freebsd.org> <k2rz-5a24-wny@FreeBSD.org> <CACM2dAaD=7uqRN89E2d1=t7yCR3GzDCy8TiB-CX1J6g2D8QD1w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 09, 2015 at 10:06:07PM -0400, Philip M. Gollucci wrote:
> Well gosh. I must not approve things while crszy.
>
> Thanks Jan!
Seconded! Thanks Jan.
>
> On Wednesday, September 9, 2015, Jan Beich <jbeich@freebsd.org> wrote:
>
> > Jason Unovitch <junovitch@FreeBSD.org> writes:
> >
> > > +post-patch:
> > > + ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \
> >
> > CC is defined by default to a sane value in both GNU and BSD make.
> > One can do '/^CC/d' but see below for better way.
The intent was to catch the hard coded CC = cc in the port's config.mk.
This port doesn't seem to respect getting CC passed by MAKE_ENV.
> >
> > > + -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \
> > ^^^
> > Typo: l .vs I. It still works because PREFIX is also passed via MAKE_ENV.
I'm not sure how I managed to miss that one.
> >
> > > + -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \
> > > + ${WRKSRC}/config.mk
> >
> > If possible try to avoid patching makefiles if overriding a few
> > variables is enough. For one, your entire post-patch can be:
> >
> > MAKE_ARGS= CC="${CC}" PREFIX="${PREFIX}" MANPREFIX="${MANPREFIX}"
> >
>
Working on the corrections now. Thanks again!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150910021723.GA7969>