From owner-svn-src-head@freebsd.org  Mon Sep 12 08:32:33 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE9E3BD7B7F;
 Mon, 12 Sep 2016 08:32:33 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 597F01B3;
 Mon, 12 Sep 2016 08:32:33 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u8C8WSST061504
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Mon, 12 Sep 2016 11:32:28 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u8C8WSST061504
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id u8C8WSkS061503;
 Mon, 12 Sep 2016 11:32:28 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Mon, 12 Sep 2016 11:32:28 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Sepherosa Ziehau <sephe@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r305722 - head/sys/x86/x86
Message-ID: <20160912083228.GW38409@kib.kiev.ua>
References: <201609120457.u8C4vw9S052665@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201609120457.u8C4vw9S052665@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Sep 2016 08:32:33 -0000

On Mon, Sep 12, 2016 at 04:57:58AM +0000, Sepherosa Ziehau wrote:
> Author: sephe
> Date: Mon Sep 12 04:57:58 2016
> New Revision: 305722
> URL: https://svnweb.freebsd.org/changeset/base/305722
> 
> Log:
>   x86: Use sx lock for interrupt sources.
>   
>   - Certain pic_assign_cpu, e.g. msi_assign_cpu can have quite a long
>     call chain.  For msi_assign_cpu, mutex makes complex PCI bridge
>     drivers more tricky, e.g. sleep can note be called, etc, it will
>     be pretty tricky for upcoming Hyper-V PCI bridge driver for PCI
>     pass-through.

>   - It is not used on any hot code path nor non-sleepable context, so
>     sx should have the same effect as mutex.
Did you tested ACPI_DMAR interrupt remapping mode with your patch and
witness enabled ?

>   
>   PIC list is still protected by mutex to keep suspend/resume work.