From owner-cvs-src@FreeBSD.ORG Tue Sep 19 12:52:01 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 551BB16A416; Tue, 19 Sep 2006 12:52:01 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D41B43D46; Tue, 19 Sep 2006 12:52:00 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k8JCpwGr007384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Sep 2006 16:51:59 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k8JCpwDU007383; Tue, 19 Sep 2006 16:51:58 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 19 Sep 2006 16:51:58 +0400 From: Gleb Smirnoff To: John Baldwin Message-ID: <20060919125158.GF27667@FreeBSD.org> References: <200609171333.k8HDXUht029746@repoman.freebsd.org> <200609181354.19593.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200609181354.19593.jhb@freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/bge if_bge.c src/sys/dev/em if_em.c src/sys/dev/ixgb if_ixgb.c src/sys/dev/nfe if_nfe.c src/sys/dev/nge if_nge.c src/sys/dev/re if_re.c src/sys/dev/stge if_stge.c src/sys/dev/ti if_ti.c src/sys/dev/txp ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2006 12:52:01 -0000 On Mon, Sep 18, 2006 at 01:54:18PM -0400, John Baldwin wrote: J> Did you ever get a chance to benchmark this? I know in principle it should be J> faster, but as I had mentioned to you earlier, sometimes things that seem J> like they should be faster end up being slower, so it's generally helpful to J> verify one's assumptions with actual benchmarks or testing, etc. Also, it J> would have been helpful to have Robert's review on this as he has been J> talking about moving the vlan stuff into the ether input/output routines for J> quite a while now. /me seconds. When introducing the mtag UMA zone I've done benchmarking, that proved that this change should go into CVS. I'd appreciate if the removal would be confirmed with a benchmark result. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE