Date: Wed, 5 Mar 1997 15:13:56 -0800 (PST) From: pius@iago.ienet.com To: freebsd-gnats-submit@freebsd.org Subject: gnu/2888: chown in gnu/usr.bin/groff/mm/Makefile uses '.' instead of ':' to separate user from group Message-ID: <199703052313.PAA18497@freefall.freebsd.org> Resent-Message-ID: <199703052320.PAA18826@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 2888
>Category: gnu
>Synopsis: chown in gnu/usr.bin/groff/mm/Makefile uses '.' instead of ':' to separate user from group
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Mar 5 15:20:03 PST 1997
>Last-Modified:
>Originator: Pius Fischer
>Organization:
>Release: 2.2-961006-SNAP
>Environment:
FreeBSD iago.ienet.com 2.2-961006-SNAP FreeBSD 2.2-961006-SNAP #0: Tue Jan 7 13:59:56 PST 1997 terryl@iago.ienet.com:/usr/src/sys/compile/IAGO i386
>Description:
There are two occurrences of chown in /usr/src/gnu/usr.bin/groff/mm/Makefile
that use a period instead of a colon to separate the user from the group.
This is a problem if chown is compiled without -DSUPPORT_DOT.
The man page for chown(8) even says that the group operand must be
preceded by a ':' and that previous versions of chown used a '.' to
distinguish the user from the group but that this has been changed
to a ':' so that user and group names can contain a dot. However,
the man page isn't quite right since by default chown is compiled
with -DSUPPORT_DOT.
>How-To-Repeat:
compile chown without -DSUPPORT_DOT, install it, and do a make world
(the build falls over towards the end of the build-tools target)
>Fix:
/usr/src/gnu/usr.bin/groff/mm>diff -u Makefile~ Makefile
--- Makefile~ Mon Sep 9 11:05:26 1996
+++ Makefile Wed Mar 5 14:43:20 1997
@@ -19,7 +19,7 @@
${DIST_DIR}/tmac.m $(DESTDIR)$(TMACDIR)/tmac.mse
test -d $(DESTDIR)$(TMACDIR)/mm || mkdir $(DESTDIR)$(TMACDIR)/mm
- chown $(TMACOWN).$(TMACGRP) $(DESTDIR)$(TMACDIR)/mm
+ chown $(TMACOWN):$(TMACGRP) $(DESTDIR)$(TMACDIR)/mm
chmod 755 $(DESTDIR)$(TMACDIR)/mm
for f in $(FILES); do \
@@ -29,7 +29,7 @@
for f in $(LOCALE); do \
test -f $(DESTDIR)$(TMACDIR)/mm/$$f || \
touch $(DESTDIR)$(TMACDIR)/mm/$$f; \
- chown $(TMACOWN).$(TMACGRP) $(DESTDIR)$(TMACDIR)/mm/$$f; \
+ chown $(TMACOWN):$(TMACGRP) $(DESTDIR)$(TMACDIR)/mm/$$f; \
chmod $(TMACMODE) $(DESTDIR)$(TMACDIR)/mm/$$f; \
done
/usr/src/gnu/usr.bin/groff/mm>
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703052313.PAA18497>