From owner-cvs-all@FreeBSD.ORG Mon Aug 29 13:03:36 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C7AF106564A; Mon, 29 Aug 2011 13:03:36 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id D8DAA8FC15; Mon, 29 Aug 2011 13:03:35 +0000 (UTC) Received: by iadx2 with SMTP id x2so635461iad.13 for ; Mon, 29 Aug 2011 06:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=3fD8arRugi8a4PwhWBilUTZqgE/npWLyEnlY7EzT2hs=; b=eCl4UpTgXdc47H7yDkWJmZkoNhvCuQ2t6OjxaL7TjQryI/d+cUd4fnWeJNWZ5gwHTR Oafiamvflh3HWKSzDxIMukz84UhUaZ7JN8YECGg15qS1OETJbLITHGhfjMRKF1/yOWS0 w2WZfbHez0ro5qE3JScKfQ/3hO5Hgog8u/6/o= Received: by 10.231.41.69 with SMTP id n5mr10463160ibe.92.1314623015228; Mon, 29 Aug 2011 06:03:35 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.231.61.148 with HTTP; Mon, 29 Aug 2011 06:03:05 -0700 (PDT) In-Reply-To: <20110826200234.GA8743@FreeBSD.org> References: <201108261828.p7QISje3085996@repoman.freebsd.org> <20110826200234.GA8743@FreeBSD.org> From: Chris Rees Date: Mon, 29 Aug 2011 14:03:05 +0100 X-Google-Sender-Auth: y6kqACWMZWYWj0lGuC3EAlNRIz0 Message-ID: To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Koop Mast , cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/textproc/ots Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2011 13:03:36 -0000 2011/8/26 Alexey Dokuchaev : > On Fri, Aug 26, 2011 at 06:28:45PM +0000, Koop Mast wrote: >> kwm =A0 =A0 =A0 =A0 2011-08-26 18:28:45 UTC >> >> =A0 Modified files: >> =A0 =A0 textproc/ots =A0 =A0 =A0 =A0 Makefile >> =A0 Log: >> =A0 Mark MAKE_JOBS_UNSAFE. > > Just replying to a random MAKE_JOBS_UNSAFE commit. =A0I have a suggestion > which I think would help us to fix parallel builds when portmgr@ decides = to > start running -exp runs with forced MAKE_JOBS: every time one of us marks= a > port as MAKE_JOBS_UNSAFE, should provide a short comment on the nature of= a > failure. =A0While in majority of cases it can hardly be generalized as it= is > probably due to the incorrectly defined dependencies, sometimes it's one > of the well-known cases: missing `-p' switch to mkdir(1) calls, GNU make = vs. > BSD make (devel/nasm is an example of this particular case), or if it onl= y > fails for -j4 but not -j2. > > Perhaps MAKE_JOBS_UNSAFE knob could be refactored into something similar = to > other "brokenness" knobs and tought to accept a reason string, while "yes= " > value could still be used for cases when exact cause of breakage is not s= o > obvious. > > I also encourage everyone who experience brokenness during parallel build= s > check what popular GNU/Linux distros think about it. =A0AFAIK, Gentoo doe= s > parallel builds by default, and explicitly passes -j1 in their ebuilds if > they don't have relevant patch. =A0Sometimes the patch exists, in which c= ase > it should be backported to FreeBSD. =A0Ditto for OpenBSD, Debian, RedHat.= .. > There's no reason a comment can't be put into MAKE_JOBS_UNSAFE; [crees@hydra]~% echo /usr/ports/Mk/* | xargs grep '^[^#].*MAKE_JOBS_UNSAFE' /usr/ports/Mk/bsd.port.mk:.if defined(DISABLE_MAKE_JOBS) || defined(MAKE_JOBS_UNSAFE) Chris