From nobody Sun May 3 12:51:31 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g7l5s2n3Jz6cddk for ; Sun, 03 May 2026 12:51:45 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g7l5s0BWzz3tjM for ; Sun, 03 May 2026 12:51:45 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-50e5bea4045so27677041cf.3 for ; Sun, 03 May 2026 05:51:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777812703; cv=none; d=google.com; s=arc-20240605; b=ROTDPycgeCaVsey4gRl/+CARj7AqWeCIsKAAdn9g9JgorXnBqM0qLtRuIQSDetplo3 E/6uDYXzJV5AcEcrcK07EoYLahCbXAqMTRLTJyfSjCL54GyHGRLcfoaiGdL3yTTDGvu/ FAUpjftJV4ENacU3EJUHornJSt4HW8KqFu1ZW0cqmdyNtqGku00NmuBo2OmkDBN04+ft pYoKjko+GIrfQQnesuJITi4ArdN4wyCjKUvZXs9psbJprmSUaG2AJ4q8Pv8HSJFEbMfe yNsNyTWRcX+K1iKNF9LoaE7SnzXkcP7sn5lCUqqds+HS6VyjOfRsrUoLxeBL4bcQOcKL tLFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=4OQ7a2FrwuhOZYsfbzBZ/mKGFPh2GYk1QKMaU9MRzV8=; fh=ZxBZn4z75GVg3qeVCeZ+3lUOtkT9djm9P4u5ZQE0dRU=; b=AjZCpRjdCF4LzrQM0+CcqYxNqAdLcwUPEcUPrHGewM2b5Z/K6w7arbGhy/Qj0PiEYf Qglvl2Er1Ht6zeLzSrIMPdznZkNvI8d6jnLstXCnZE3+4zMZBRJDweFCvkO+XxWYWvwX FVt84FJxa5Rz5Pkh6lXBgGnURegRbPQzXJyTK4oIsplDjI60D/foL9GMBbFn0Xmud9H9 txv84buaIWhRTyJr3pJsSorgQXL5dnk1AvHGdtaIoQrEquFNIq0l5AMDxIz+djhDbkGc 7fh1VKwyW1JkjnXK7dZ/fgDX7g8gPygvTnqrvMNdWyOJKAALvW7JyHSLRS85lAt6UCLd VEIg==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1777812703; x=1778417503; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4OQ7a2FrwuhOZYsfbzBZ/mKGFPh2GYk1QKMaU9MRzV8=; b=A4Gs8/jkOSaf4ViQlVppfibwFEaC34/xDr+BzI6krVlCBe2YWMwyYFnalV7kzvPqCS 0HYXX/N+WmZbKqWyOvYnN/dOTu1k/Qhdaxz+i+Xx7oNJjuJZvEBj4kahd9KMKjbmiP6y nhLNqd7DaMkmKHCjDEpx29TXNx07veVbCVEEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777812703; x=1778417503; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4OQ7a2FrwuhOZYsfbzBZ/mKGFPh2GYk1QKMaU9MRzV8=; b=DtIVr7Ou/btRvLyUcWGieRmZXv9SzzPg1NLn2ELmt5uico+CETc2owxtlVUmKfHFZV VjGqshDKuOxen70APeX9UP6BymZ+NqGH9ticH/vz35amVDLkrpqaJLaLawAtr57Cb/bW Ouy01Gl2bTLEp5KIRSiy55h/VI/ioF3MmaLfFjpfRhtzZnxDgpmmlr6i7ANZMO0WoCZy zDuIY4t2ZIwb4zu3Sphtvj5uta6IRi5cpDj+EtNFPd5tbr3LeMeAKbm6cWch8D7SvW0j 0NEeQVuISudNERnl9AoPkiw9eLTASJQnKwEGIz7xJe7tRITtRlmxsB0fxNbjnv5erY1g dVyg== X-Forwarded-Encrypted: i=1; AFNElJ9DRiztQazES2Kpc1bt7Ait7dmQaHovgHiJz1EP1WNpbXttgT2N++O3OjcdIfb6HZuW2M9tTHSB/13ySTOxuid4unZA3A==@freebsd.org X-Gm-Message-State: AOJu0YzqDWiORn3lxlKGi0ElqsIc2GOrfAyIKnebRuON3Ck+y556wLLZ G4mgV+AGmzO9tLE4tAREpfTVMes8jqzDGQCUKLcN0RVVx7zeyKGPg6g2RqdDj4u0lUU++IBIOcX RLLB0bl0sCrdYZVbJR4SLCPBbbzP4Pjs/WHbliRk4 X-Gm-Gg: AeBDietBPZHZ20uQfQ48iOnc29wsNG0/BFTUVAxXY3lzxRJ6Qos3OsSVaolRrFwWISa oQNcCeuXmASfUjjT5zzSl3XxMf7X56M6j5Tzrbm088xPU0JtMIoFvFTmTM1VmxqnIMlmqFVfPrb NWZjrIO3JZBUOHtpQS2cOJYi//fCsoQ0S1Z79GPsaYXDyQqs1j6gSGpqZ/NEFV7H5EVdMGzeAPd ZyBuH/wr/ZrMFERqSxmXnYh1Mx7ANW5UMHc47PNYvD0kSzv/oata3XmUs6XQ+3GG+5zbJ7LE/Rh yzKGqgGJCUocMYMEaJq5LmK4CgOkbueEl5KyvWwSYXFpKL4SAQqNa3NkxdGLxZ7Yj51osZ3RElN 365isgDrjtCSqf5TiojLFGrO29rftk+NKp5ZT8hEg24gttVV5q9WWlV2e4UU5 X-Received: by 2002:ac8:7f8b:0:b0:50d:7f66:dca with SMTP id d75a77b69052e-5104bf0a227mr89532101cf.33.1777812703139; Sun, 03 May 2026 05:51:43 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <69f6b1ec.181e8.27d0b938@gitrepo.freebsd.org> In-Reply-To: <69f6b1ec.181e8.27d0b938@gitrepo.freebsd.org> From: Kevin Bowling Date: Sun, 3 May 2026 05:51:31 -0700 X-Gm-Features: AVHnY4K-LnPI4NKGjAnma1t4ZNjScc4DYQ520slFdqW4NJ2fhDKKlc2p2xJ6hvU Message-ID: Subject: Re: git: 01674e15dedb - main - bsd.endian.mk: Optimize the handling of big/little endian determination. To: "Stephen J. Kiernan" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4g7l5s0BWzz3tjM X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Sat, May 2, 2026 at 7:24=E2=80=AFPM Stephen J. Kiernan wrote: > > The branch main has been updated by stevek: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D01674e15dedb15f8ce498af068= 0c50bb075c5482 > > commit 01674e15dedb15f8ce498af0680c50bb075c5482 > Author: Stephen J. Kiernan > AuthorDate: 2024-04-03 23:25:19 +0000 > Commit: Stephen J. Kiernan > CommitDate: 2026-05-03 02:21:56 +0000 > > bsd.endian.mk: Optimize the handling of big/little endian determinati= on. > > Add variables to contain lists of MACHINE_ARCH values to use > to determine little or big endian. > > Only error out about not being able to determine endianess if > TARGET_ENDIANNESS is empty and not cross-compiling. > > Reviewed by: sjg > Obtained from: Hewlett Packard Enterprise Development LP > Differential Revision: https://reviews.freebsd.org/D44629 > --- > share/mk/bsd.endian.mk | 39 +++++++++++++++++++++++++++++---------- > 1 file changed, 29 insertions(+), 10 deletions(-) > > diff --git a/share/mk/bsd.endian.mk b/share/mk/bsd.endian.mk > index 0c5ebb7aeba2..2a617a1d2794 100644 > --- a/share/mk/bsd.endian.mk > +++ b/share/mk/bsd.endian.mk > @@ -1,20 +1,35 @@ > > -.if ${MACHINE_CPUARCH} =3D=3D "aarch64" || \ > - ${MACHINE_CPUARCH} =3D=3D "arm" || \ > - ${MACHINE_ARCH} =3D=3D "amd64" || \ > - ${MACHINE_ARCH} =3D=3D "i386" || \ > - ${MACHINE_ARCH} =3D=3D "powerpc64le" || \ > - ${MACHINE_CPUARCH} =3D=3D "riscv" > +MACHINE_ARCH_LIST.little =3D \ > + aarch64 \ > + amd64 \ > + armv7 \ > + i386 \ > + powerpc64le \ > + riscv* > + > +MACHINE_ARCH_LIST.big =3D \ > + powerpc \ > + powerpc64 > + > +.for e in big little > +N_$e:=3D ${MACHINE_ARCH_LIST.$e:${M_ListToSkip}} > +.endfor > + > +# For the host, we need to look at the host architecture > +.if ${MACHINE:Nhost*} =3D=3D "" > +_ENDIAN_ARCH=3D${_HOST_ARCH} > +.else > +_ENDIAN_ARCH=3D${MACHINE_ARCH} > +.endif > + > +.if ${_ENDIAN_ARCH:${N_little}} =3D=3D "" > TARGET_ENDIANNESS=3D 1234 > CAP_MKDB_ENDIAN=3D -l > LOCALEDEF_ENDIAN=3D -l > -.elif ${MACHINE_ARCH} =3D=3D "powerpc" || \ > - ${MACHINE_ARCH} =3D=3D "powerpc64" > +.elif ${_ENDIAN_ARCH:${N_big}} =3D=3D "" > TARGET_ENDIANNESS=3D 4321 > CAP_MKDB_ENDIAN=3D -b > LOCALEDEF_ENDIAN=3D -b > -.elif ${.MAKE.OS} =3D=3D "FreeBSD" > -.error Don't know the endian of this architecture > .else > # > # During bootstrapping on !FreeBSD OSes, we need to define some value. = Short of > @@ -33,3 +48,7 @@ TARGET_ENDIANNESS=3D 1234 > CAP_MKDB_ENDIAN=3D -B # Poisoned value, invalid flags for both cap_mk= db > LOCALEDEF_ENDIAN=3D -B # and localedef. > .endif > + > +.if empty(TARGET_ENDIANNESS) && ${.MAKE.OS} =3D=3D "FreeBSD" > +.error Don't know the endianness of this architecture > +.endif This might be breaking poudriere pkg builds i.e. graphics/drm-66-kmod: make[1]: /usr/share/mk/bsd.endian.mk:25: Unknown modifier ":aarch64 amd64 armv7 i386 powerpc64le riscv*" while evaluating indirect modifiers "aarch64 amd64 armv7 i386 powerpc64le riscv*" while evaluating variable "_ENDIAN_ARCH" with value "amd64" in /usr/share/mk/bsd.endian.mk:25 in .for loop from /usr/share/mk/bsd.compiler.mk:160 with cc =3D CC, X_ =3D ${_empty_var_} in /usr/share/mk/bsd.own.mk:297 in /usr/share/mk/bsd.init.mk:21 in /usr/src/sys/conf/kern.opts.mk:21 in /wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.25= _10/Makefile:4 in make[1] in directory "/wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.25_10" make[1]: /usr/share/mk/bsd.endian.mk:53: Don't know the endianness of this architecture in .for loop from /usr/share/mk/bsd.compiler.mk:160 with cc =3D CC, X_ =3D ${_empty_var_} in /usr/share/mk/bsd.own.mk:297 in /usr/share/mk/bsd.init.mk:21 in /usr/src/sys/conf/kern.opts.mk:21 in /wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.25= _10/Makefile:4 in make[1] in directory "/wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.25_10" make[1]: stopped making "obj" in /wrkdirs/usr/ports/graphics/drm-66-kmod/work/drm-kmod-drm_v6.6.25_10 *** Error code 1