From owner-freebsd-ports@freebsd.org Sat May 14 04:58:46 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57882B3A306 for ; Sat, 14 May 2016 04:58:46 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 473801230 for ; Sat, 14 May 2016 04:58:46 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: by mailman.ysv.freebsd.org (Postfix) id 46A1EB3A305; Sat, 14 May 2016 04:58:46 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46531B3A304 for ; Sat, 14 May 2016 04:58:46 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [192.108.105.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.soaustin.net", Issuer "StartCom Class 2 IV Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2B43E122F; Sat, 14 May 2016 04:58:45 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from lonesome.com (bones.soaustin.net [192.108.105.22]) by mail.soaustin.net (Postfix) with ESMTPSA id E3080250; Fri, 13 May 2016 23:49:16 -0500 (CDT) Date: Fri, 13 May 2016 23:49:15 -0500 From: Mark Linimon To: Julian Elischer Cc: "ports@FreeBSD.org" Subject: Re: suggested patch for bsd.ports.mk Message-ID: <20160514044915.GA13340@lonesome.com> References: <3ce42b02-ac65-0322-b66d-5e5d198c9877@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ce42b02-ac65-0322-b66d-5e5d198c9877@freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 May 2016 04:58:46 -0000 On Sat, May 14, 2016 at 11:25:08AM +0800, Julian Elischer wrote: > so who or what decides if I can put this in? portmgr. From the portmgr pages: Changes to bsd.port.mk are not the only commits that can have a drastic effect on the tree. We request that any such changes also be tested on the cluster. Examples of such changes that should be tested before committing include: changes to packages with many dependencies, including X11 servers, GNOME, KDE, gettext, autotools, and so forth changes that change the "accepted best practice" for ports Makefiles, such as definitions or usage of common make variables (or Makevars). (e.g. consolidation of various implementations of USE_*, WITH_*, and so forth) large repocopies (such as when an existing port category is divided up) If you are unsure of whether your proposed change will require a regression test, please send email to portmgr@FreeBSD.org. ---------------- What this doesn't say is that, by convention, portmgr tests all changes to bsd.port.mk on an experimental (exp-) run on the cluster. The motivation is that many people auto-update their ports trees every day, and any breakage generates immediatel, ah, feedback. In general minor changes are piggybacked onto major changes during an exp- run. tl;dr: file a PR and assign to it portmgr@ under 'ports infrastructure'. mcl