From owner-svn-src-all@freebsd.org Sat Aug 22 10:41:02 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 191833B5F64; Sat, 22 Aug 2020 10:41:02 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BYZg06Z7tz4SBM; Sat, 22 Aug 2020 10:41:00 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-ed1-f68.google.com with SMTP id b2so3666863edw.5; Sat, 22 Aug 2020 03:41:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cNQgeOEzvvGFN3vA4Zziq7/6aYM28pGjfU/WLhSFQoc=; b=gFzADxa9bWDUr4WrQK3Ih0wXtDRs37ClK/U3I9pRclmXOLCUFFxJQt8BEQQc2rL85c H5uirxKePzkQScrwc0K+TPCKDPMjUzCvu8KX6+VLl6HP5C6RCRT2Ip0o7ihZxrgPQAFz M2hEmdGgx4DB5b1BQItASKYw2+mZw3N2zHt/x3VUCRS61ZVyeOUPUxOnrXlaza/ca/iG wV/dQvVRK5Md4Gf2Nb0a7b74T/pdh6V3WD4bmMKRlb8EiZiUW9QN9gi1DubiztZyzYz2 PHtBBpj5MlF4nYgoVkn5+tBCAU5InKTiNvuxy4mp+cPlx2KxkuIkBpNR1jOyUmL14xko 7i5A== X-Gm-Message-State: AOAM533JQRqfUBYe5F0qJUbt2HhYlyst0mQnAZozNwydf0bCeChuLJ79 sTQipBoKHadqg+tTaCyAtTLBuy2GLonJ+VdkEgC4galaQ5E= X-Google-Smtp-Source: ABdhPJw9qg65Ny6nV+uDAV7m8Opz/46xamwxUBuolXRbc9MoOkUTuA/gZr7zd0UQ4hyhKFIXHd1a1YhTc1+S6/Z4j2c= X-Received: by 2002:a05:6402:1443:: with SMTP id d3mr7085795edx.40.1598092859376; Sat, 22 Aug 2020 03:40:59 -0700 (PDT) MIME-Version: 1.0 References: <202008201928.07KJSJfP088877@repo.freebsd.org> In-Reply-To: <202008201928.07KJSJfP088877@repo.freebsd.org> From: Antoine Brodin Date: Sat, 22 Aug 2020 12:40:49 +0200 Message-ID: Subject: Re: svn commit: r364438 - in head/cddl: contrib/opensolaris/lib/libdtrace/common usr.sbin/dtrace/tests/tools To: Mark Johnston Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BYZg06Z7tz4SBM X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of antoinebrodinfreebsd@gmail.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=antoinebrodinfreebsd@gmail.com X-Spamd-Result: default: False [0.02 / 15.00]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.02)[0.016]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.68:from]; FORGED_SENDER(0.30)[antoine@freebsd.org,antoinebrodinfreebsd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.68:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[antoine@freebsd.org,antoinebrodinfreebsd@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2020 10:41:02 -0000 On Thu, Aug 20, 2020 at 9:28 PM Mark Johnston wrote: > > Author: markj > Date: Thu Aug 20 19:28:19 2020 > New Revision: 364438 > URL: https://svnweb.freebsd.org/changeset/base/364438 > > Log: > Enable creation of static userspace probes in incremental builds. > > To define USDT probes, dtrace -G makes use of relocations for undefined > symbols: the target address is overwritten with NOPs and the location is > recorded in the DOF section of the output object file. To avoid link > errors, the original relocation is destroyed. However, this means that > the same input object file cannot be processed multiple times, as > happens during incremental rebuilds. Instead, only set the relocation > type to NONE, so that all information required to reconstruct USDT > probes is preserved. > > Reported by: bdrewery > MFC after: 3 weeks > Sponsored by: The FreeBSD Foundation > > Modified: > head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c > head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_strtab.c > head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_strtab.h > head/cddl/usr.sbin/dtrace/tests/tools/exclude.sh Hi, This change seems broken on i386: http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5-devel-5.33.0.262.log http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5.28-5.28.3.log http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5.30-5.30.3.log http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs/perl5-5.32.0.log Cheers, Antoine