From owner-cvs-all Mon Apr 9 3:52:51 2001 Delivered-To: cvs-all@freebsd.org Received: from knight.cons.org (knight.cons.org [194.233.237.86]) by hub.freebsd.org (Postfix) with ESMTP id ABD6E37B424; Mon, 9 Apr 2001 03:52:44 -0700 (PDT) (envelope-from cracauer@knight.cons.org) Received: (from cracauer@localhost) by knight.cons.org (8.11.1/8.11.1) id f39Aqfi15890; Mon, 9 Apr 2001 12:52:41 +0200 (CEST) Date: Mon, 9 Apr 2001 12:52:40 +0200 From: Martin Cracauer To: Brian Somers Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/sh parser.c Message-ID: <20010409125240.A15655@cons.org> References: <200104041011.f34ABhD62212@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200104041011.f34ABhD62212@freefall.freebsd.org>; from brian@FreeBSD.ORG on Wed, Apr 04, 2001 at 03:11:43AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In <200104041011.f34ABhD62212@freefall.freebsd.org>, Brian Somers wrote: > brian 2001/04/04 03:11:43 PDT > > Modified files: > bin/sh parser.c > Log: > A much better (more correct) fix for handling ``!'' characters This is broken for pipes in ! constructs. Try this: if ! echo bla | wc -c ; then echo broken fi if ! wc -c /etc/hosts ; then echo broken fi I am available for reviews of sh fixes. Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer http://www.cons.org/cracauer/ As far as I'm concerned, if something is so complicated that you can't ex- plain it in 10 seconds, then it's probably not worth knowing anyway -Calvin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message