From owner-freebsd-embedded@FreeBSD.ORG Wed Oct 23 16:08:45 2013 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6B599120; Wed, 23 Oct 2013 16:08:45 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2AEC629F6; Wed, 23 Oct 2013 16:08:44 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r9NG8hIG091732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Oct 2013 09:08:44 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id r9NG8hjo091731; Wed, 23 Oct 2013 09:08:43 -0700 (PDT) (envelope-from jmg) Date: Wed, 23 Oct 2013 09:08:43 -0700 From: John-Mark Gurney To: Ian Lepore Subject: Re: new ofw_search_compatible() Message-ID: <20131023160843.GG56872@funkthat.com> Mail-Followup-To: Ian Lepore , freebsd-embedded@freebsd.org References: <1382539150.92499.206.camel@revolution.hippie.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1382539150.92499.206.camel@revolution.hippie.lan> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Wed, 23 Oct 2013 09:08:44 -0700 (PDT) Cc: freebsd-embedded@freebsd.org X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2013 16:08:45 -0000 Ian Lepore wrote this message on Wed, Oct 23, 2013 at 08:39 -0600: > While creating drivers that work for a variety of SoCs, I increasingly > find myself coding sequences such as: > > if (ofw_bus_is_compatible(dev, "fsl,imx51-fec")) > sc->fectype = FECTYPE_IMX51; > else if (ofw_bus_is_compatible(dev, "fsl,imx53-fec")) > sc->fectype = FECTYPE_IMX53; > else if (ofw_bus_is_compatible(dev, "fsl,imx6q-fec")) > sc->fectype = FECTYPE_IMX6; > else > sc->fectype = FECTYPE_GENERIC; > > That's a short list as an example, eventually that driver may support a > dozen SoCs. I'd like to add a helper routine that turns this into a > table lookup, patch attached. Any objections? It turns sequences such > as the above into: > > static struct ofw_compat_data compat_data[] = { > {"fsl,imx51-fec", FECTYPE_IMX51}, > {"fsl,imx53-fec", FECTYPE_IMX53}, > {"fsl,imx6q-fec", FECTYPE_IMX6}, > {NULL, FECTYPE_NONE}, > }; > /* ... */ > sc->fectype = ofw_bus_search_compatible(dev, compat_data)->ocd_data; > > The search routine by design can't return NULL unless you pass it a NULL > table pointer. That lets you provide whatever "not found" value in the > table-end sentry that works best for the way your code is structured. Some comments would be good... Like a brief usage, such as the requirement that the table end w/ NULL w/ a proper data return... a man page would be even better, but no one has written any for the ofw stuff yet.. :( -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."