Date: Sun, 31 Dec 2023 08:00:35 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Muhammad Moinur Rahman <bofh@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: afcde63b907f - main - games/slump: Jettison byteswap/endian hacks Message-ID: <zfxq-hn58-wny@FreeBSD.org> In-Reply-To: <202312310426.3BV4QjwI034777@gitrepo.freebsd.org> (Muhammad Moinur Rahman's message of "Sun, 31 Dec 2023 04:26:45 GMT") References: <202312310426.3BV4QjwI034777@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Muhammad Moinur Rahman <bofh@FreeBSD.org> writes:
> diff --git a/games/slump/files/patch-dump.c b/games/slump/files/patch-dump.c
> deleted file mode 100644
> index 44bf886aaa69..000000000000
> --- a/games/slump/files/patch-dump.c
> +++ /dev/null
> @@ -1,15 +0,0 @@
> ---- ./dump.c.orig Sun May 29 23:48:57 2005
> -+++ ./dump.c Mon Oct 9 23:53:07 2006
> -@@ -36,6 +36,12 @@
> - #include <assert.h>
> - #include "slump.h"
> -
> -+#include <machine/endian.h>
> -+
> -+#if BYTE_ORDER == BIG_ENDIAN
> -+#define ENDIAN_BIG
> -+#endif
${WRKSRC}/Makefile.big-endian is unused but nothing else defines ENDIAN_BIG.
I think, this part should be reverted and/or converted to <endian.h>.
See also https://austingroupbugs.net/view.php?id=162
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?zfxq-hn58-wny>