From owner-freebsd-pf@FreeBSD.ORG  Wed Jun 19 13:39:14 2013
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id EF407464;
 Wed, 19 Jun 2013 13:39:14 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 by mx1.freebsd.org (Postfix) with ESMTP id AAB2D123F;
 Wed, 19 Jun 2013 13:39:13 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id r5JDdCcQ002852;
 Wed, 19 Jun 2013 17:39:12 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id r5JDdCXh002851;
 Wed, 19 Jun 2013 17:39:12 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 19 Jun 2013 17:39:12 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Nikos Vassiliadis <nvass@gmx.com>
Subject: Re: de-virtualize pf sysctls
Message-ID: <20130619133912.GD1214@glebius.int.ru>
References: <51B33B8B.9050006@gmx.com> <51B344B8.9090109@gmx.com>
 <20130612185150.GA6553@gmail.com> <51BD9DF3.1080808@gmx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <51BD9DF3.1080808@gmx.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Mikolaj Golub <trociny@FreeBSD.org>, freebsd-pf@freebsd.org
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
 \(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2013 13:39:15 -0000

On Sun, Jun 16, 2013 at 01:13:55PM +0200, Nikos Vassiliadis wrote:
N> >>> Please review this patch. These two variables are RO-tunables and
N> >>> cannot be changed at runtime. As such, it is not useful to
N> >>> virtualize them.
N> >
N> > This looks correct to me. Also, it looks like V_pf_hashmask and
N> > V_pf_srchashmask can be de-virtualized then.
N> 
N> Yes, taken care of on this version. I am not sure if I placed
N> properly pf_hashmask and pf_srchashmask in pfvar.h.
N> 
N> Please review, thanks.

Thanks, Nikos.

I committed the patch to the branch projects/pf/head. Can you
please check out this branch and generate further pf+vimage related
diffs against it?

Once we finish and stabilize it, I will merge the branch to head.


-- 
Totus tuus, Glebius.