Date: Mon, 26 Oct 2009 03:40:02 GMT From: =?ISO-8859-1?Q?Mikko_Ty=F6l=E4j=E4rvi?= <mikko.tyolajarvi@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/138830: net/linux-nx-client TCP_NODELAY problem Message-ID: <200910260340.n9Q3e2OE021459@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/138830; it has been noted by GNATS.
From: =?ISO-8859-1?Q?Mikko_Ty=F6l=E4j=E4rvi?= <mikko.tyolajarvi@gmail.com>
To: bug-followup@FreeBSD.org, meta@club.kyutech.ac.jp
Cc:
Subject: Re: ports/138830: net/linux-nx-client TCP_NODELAY problem
Date: Sun, 25 Oct 2009 20:13:49 -0700 (PDT)
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
--738249620-1503806993-1256526829=:1213
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
This patch to the port makes nxclient work for me (on 7.2):
--- Makefile.orig 2009-10-24 17:57:53.000000000 -0700
+++ Makefile 2009-10-24 17:59:15.000000000 -0700
@@ -27,6 +27,10 @@
PLIST_SUB+= PORTVERSION=${PORTVERSION}
+post-patch:
+ ${PERL5} -pi.orig -e 's/\x83\x3f\x5f\x75\x02/\x83\x3f\x16\x75\x02/' \
+ ${NXSRC}/lib/libXcomp.so.${PORTVERSION}
+
do-install:
${MKDIR} ${NXDST}/bin
${INSTALL_PROGRAM} ${NXSRC}/bin/* ${NXDST}/bin
Nxclient is blindly setting TCP_NODELAY on a number of sockets,
including the X11 unix domain socket and then ignores certain errors
as benign.
Linux returns a different error code (EOPNOTSUPP) than freebsd and
nxclient treats the unexpected error (EINVAL) code as fatal.
The patch massages the binary to be happy with the freebsd error code.
Btw, using display localhost:0 instead of :0 also makes nxclient work,
with some performance loss.
Cheers,
/Mikko
--738249620-1503806993-1256526829=:1213
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=Makefile.diff
Content-Transfer-Encoding: BASE64
Content-ID: <20091025201349.F1213@antec.home>
Content-Description:
Content-Disposition: attachment; filename=Makefile.diff
LS0tIE1ha2VmaWxlLm9yaWcJMjAwOS0xMC0yNCAxNzo1Nzo1My4wMDAwMDAw
MDAgLTA3MDANCisrKyBNYWtlZmlsZQkyMDA5LTEwLTI0IDE3OjU5OjE1LjAw
MDAwMDAwMCAtMDcwMA0KQEAgLTI3LDYgKzI3LDEwIEBADQogDQogUExJU1Rf
U1VCKz0JCVBPUlRWRVJTSU9OPSR7UE9SVFZFUlNJT059DQogDQorcG9zdC1w
YXRjaDoNCisJJHtQRVJMNX0gLXBpLm9yaWcgLWUgJ3MvXHg4M1x4M2ZceDVm
XHg3NVx4MDIvXHg4M1x4M2ZceDE2XHg3NVx4MDIvJyBcDQorCQkke05YU1JD
fS9saWIvbGliWGNvbXAuc28uJHtQT1JUVkVSU0lPTn0NCisNCiBkby1pbnN0
YWxsOg0KIAkke01LRElSfSAke05YRFNUfS9iaW4NCiAJJHtJTlNUQUxMX1BS
T0dSQU19ICR7TlhTUkN9L2Jpbi8qICR7TlhEU1R9L2Jpbg0K
--738249620-1503806993-1256526829=:1213--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910260340.n9Q3e2OE021459>